zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-26 04:28:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

Handle edge case with no default data

Browse source
This commit is contained in:
zandercymatics 2024-06-20 14:24:17 -06:00
parent 749cbeebe3
commit 36af56ea8e
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
3 changed files with 26 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/registrar/assets/js/get-gov-admin.js
View file

@ -580,14 +580,19 @@ function initializeWidgetOnList(list, parentId) {
// TODO fix edge case where nothing is selected
function handleChangeActionNeededEmail(actionNeededReasonDropdown, actionNeededEmail) {
actionNeededReasonDropdown.addEventListener("change", function() {
// TODO on change if not actionneeded on status, hide show email button
let noEmailMessage = document.getElementById("no-email-message");
const pk = document.querySelector("#domain_request_id").value;
const reason = actionNeededReasonDropdown.value;
// If a reason isn't specified, no email will be sent.
// You also cannot save the model in this state.
// This flow occurs if you switch back to the empty picker state
if(!reason) {
actionNeededEmail.value = "No email will be sent";
// Hide the text field
hideElement(actionNeededEmail);
// Show the "no email" message
showElement(noEmailMessage);
return;
}
@ -601,12 +606,18 @@ function initializeWidgetOnList(list, parentId) {
if(data && data.email_body_text) {
actionNeededEmail.value = data.email_body_text
}else if (data && !data.email_body_text) {
actionNeededEmail.value = "No email will be sent";
}
if (data) {
actionNeededEmail.value = data.email_body_text ? data.email_body_text : "No email will be sent";
// Show the text field
showElement(actionNeededEmail);
// Hide the "no email" message
hideElement(noEmailMessage);
}else if (data && !data.email_body_text) {
// Hide the text field
hideElement(actionNeededEmail);
// Show the "no email" message
showElement(noEmailMessage);
}
});
});

5
src/registrar/assets/sass/_theme/_admin.scss
View file

@ -824,3 +824,8 @@ div.dja__model-description{
.no-border {
border: none;
}
.display-none {
// Many elements in django admin try to override this, so we need !important.
display: none !important;
}

5
src/registrar/templates/django/admin/includes/detail_table_fieldset.html
View file

@ -69,7 +69,7 @@ This is using a custom implementation fieldset.html (see admin/fieldset.html)
{% block after_help_text %}
{% if field.field.name == "status" %}
<div class="flex-container {% if not filtered_audit_log_entries or not action_needed_reason %}display-none{% endif %}" id="dja-status-changelog">
<div class="flex-container {% if not filtered_audit_log_entries or not original_object.action_needed_reason %}display-none{% endif %}" id="dja-status-changelog">
<label aria-label="Status changelog"></label>
<div>
<div class="usa-table-container--scrollable collapse--dgsimple collapsed" tabindex="0">
@ -112,9 +112,10 @@ This is using a custom implementation fieldset.html (see admin/fieldset.html)
<label class="max-full" for="action_needed_reason_email_view_more">
<strong>Auto-generated email (sent to submitter)</strong>
</label>
<textarea id="action_needed_reason_email_view_more" cols="40" rows="20" class="no-border" readonly>
<textarea id="action_needed_reason_email_view_more" cols="40" rows="20" class="no-border {% if not original_object.action_needed_reason %}display-none{% endif %}" readonly>
{{ original_object.action_needed_reason_email }}
</textarea>
<p id="no-email-message" class="{% if original_object.action_needed_reason %}display-none{% endif %}">No email will be sent</p>
</div>
</div>