zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-29 17:00:02 +02:00
Code Issues Projects Releases Packages Wiki Activity

PR suggestions pt. 2

Browse source
This commit is contained in:
zandercymatics 2024-01-10 08:40:01 -07:00
parent d934897323
commit 2f5559a72f
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/registrar/tests/test_reports.py
View file

@ -223,7 +223,7 @@ class CsvReportsTest(TestCase):
self.assertEqual(expected_file_content, response.content) self.assertEqual(expected_file_content, response.content)
class ExportDataTest(MockEppLib): class ExportDataTest(TestCase):
def setUp(self): def setUp(self):
super().setUp() super().setUp()
username = "test_user" username = "test_user"

2
src/registrar/tests/test_transition_domain_migrations.py
View file

@ -86,7 +86,7 @@ class TestPatchAgencyInfo(TestCase):
def test_patch_agency_info_skip_updates_data(self): def test_patch_agency_info_skip_updates_data(self):
""" """
Tests that the `patch_federal_agency_info` command logs a warning but Tests that the `patch_federal_agency_info` command logs a warning but
updates the DomainInformation object, because an record exists in the updates the DomainInformation object, because a record exists in the
provided current-full.csv file. provided current-full.csv file.
""" """
# Set federal_agency to None to simulate a skip # Set federal_agency to None to simulate a skip

2
src/registrar/utility/csv_export.py
View file

@ -37,7 +37,7 @@ def write_row(writer, columns, domain_info):
if security_contacts: if security_contacts:
security_email = security_contacts[0].email security_email = security_contacts[0].email
invalid_emails = {"registrar@dotgov.gov", "dotgov@cisa.dhs.gov"} invalid_emails = {"registrar@dotgov.gov"}
# These are default emails that should not be displayed in the csv report # These are default emails that should not be displayed in the csv report
if security_email is not None and security_email.lower() in invalid_emails: if security_email is not None and security_email.lower() in invalid_emails:
security_email = "(blank)" security_email = "(blank)"