zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-21 20:09:23 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2572 from cisagov/dk/979-org-name-address-bug

Browse source 
Issue #979: Organization name and mailing address changes not updating log entries
This commit is contained in:
dave-kennedy-ecs 2024-08-14 15:12:55 -04:00 • committed by GitHub
commit 2ebeb148fb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/registrar/forms/domain.py
View file

@ -539,7 +539,6 @@ class DomainOrgNameAddressForm(forms.ModelForm):
elif self.is_tribal and not self._field_unchanged("organization_name"):
raise ValueError("organization_name cannot be modified when the generic_org_type is tribal")
else:
super().save()
def _field_unchanged(self, field_name) -> bool:
@ -552,6 +551,21 @@ class DomainOrgNameAddressForm(forms.ModelForm):
"""
old_value = self.initial.get(field_name, None)
new_value = self.cleaned_data.get(field_name, None)
field = self.fields[field_name]
# Check if the field has a queryset attribute before accessing it
if hasattr(field, "queryset") and isinstance(new_value, str):
try:
# Convert the string to the corresponding ID
new_value = field.queryset.get(name=new_value).id
except field.queryset.model.DoesNotExist:
pass # Handle the case where the object does not exist
elif hasattr(new_value, "id"):
# If new_value is a model instance, compare by ID.
new_value = new_value.id
return old_value == new_value