zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-13 08:07:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

Updated with review comments

Browse source
This commit is contained in:
Erin Song 2024-10-15 16:50:43 -07:00
parent b6e3405966
commit 2dd8d53ec9
No known key found for this signature in database
2 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
docs/dev-practices/code_review.md
View file

@ -12,12 +12,12 @@ After creating a pull request, pull request submitters should:
Code changes on user-facing features (excluding content updates) require approval from at least one developer and one designer.
All other changes require a single approving review.
The submitter is responsible for merging their PR unless the approver is given explcit permission. Similarly, do not commit to another person's branch unless given explicit permission.
The submitter is responsible for merging their PR unless the approver is given explicit permission. Similarly, do not commit to another person's branch unless given explicit permission.
Bias towards approving i.e. "good to merge once X is fixed" rather than blocking until X is fixed, requiring an additional review.
## Pull Requests for User-facing changes
When making user-facing changes, test that your changes work on multiple browsers including Chrome, Microsoft Edge, Firefox, and Safari.
When making or reviewing user-facing changes, test that your changes work on multiple browsers including Chrome, Microsoft Edge, Firefox, and Safari.
Add new pages to the .pa11yci file so they are included in our automated accessibility testing.
@ -29,6 +29,4 @@ Add new pages to the .pa11yci file so they are included in our automated accessi
## Coding standards
### Plain language
All functions and methods should use plain language.
TODO: Plain language description and examples in code standards ticket.
All functions and methods should use plain language.