zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-06-29 15:53:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactored _get_contacts to return default dict when no contacts exist rather then empty dict

Browse source
This commit is contained in:
David Kennedy 2023-10-18 11:04:05 -04:00
parent a587920c45
commit 2b55e40d57
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/registrar/models/domain.py
View file

@ -1743,7 +1743,14 @@ class Domain(TimeStampedModel, DomainHelper):
return dnssec_data return dnssec_data
def _get_contacts(self, contacts): def _get_contacts(self, contacts):
cleaned_contacts = {} choices = PublicContact.ContactTypeChoices
# We expect that all these fields get populated,
# so we can create these early, rather than waiting.
cleaned_contacts = {
choices.ADMINISTRATIVE: None,
choices.SECURITY: None,
choices.TECHNICAL: None,
}
if contacts and isinstance(contacts, list) and len(contacts) > 0: if contacts and isinstance(contacts, list) and len(contacts) > 0:
cleaned_contacts = self._fetch_contacts(contacts) cleaned_contacts = self._fetch_contacts(contacts)
return cleaned_contacts return cleaned_contacts