zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-06 01:35:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

removed some logging; fixed some existing unit tests

Browse source
This commit is contained in:
David Kennedy 2023-10-23 22:10:03 -04:00
parent 0e95ff6478
commit 293eb40cff
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
3 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/registrar/models/domain.py
View file

@ -324,7 +324,6 @@ class Domain(TimeStampedModel, DomainHelper):
)
elif ip is not None and ip != [] and ip != ['']:
for addr in ip:
logger.info(f"ip address {addr}")
if not cls._valid_ip_addr(addr):
raise NameserverError(
code=nsErrorCodes.INVALID_IP, nameserver=nameserver, ip=ip
@ -339,7 +338,6 @@ class Domain(TimeStampedModel, DomainHelper):
isValid (boolean)-True for valid ip address"""
try:
ip = ipaddress.ip_address(ipToTest)
logger.info(ip.version)
return ip.version == 6 or ip.version == 4
except ValueError:

4
src/registrar/tests/common.py
View file

@ -755,7 +755,7 @@ class MockEppLib(TestCase):
mockDataInfoHosts = fakedEppObject(
"lastPw",
cr_date=datetime.datetime(2023, 8, 25, 19, 45, 35),
addrs=["1.2.3.4", "2.3.4.5"],
addrs=[common.Ip(addr="1.2.3.4"), common.Ip(addr="2.3.4.5")],
)
mockDataHostChange = fakedEppObject(
@ -810,7 +810,7 @@ class MockEppLib(TestCase):
"ns2.nameserverwithip.gov",
"ns3.nameserverwithip.gov",
],
addrs=["1.2.3.4", "2.3.4.5"],
addrs=[common.Ip(addr="1.2.3.4"), common.Ip(addr="2.3.4.5")],
)
infoDomainCheckHostIPCombo = fakedEppObject(

2
src/registrar/tests/test_models_domain.py
View file

@ -107,7 +107,7 @@ class TestDomainCache(MockEppLib):
}
expectedHostsDict = {
"name": self.mockDataInfoDomain.hosts[0],
"addrs": self.mockDataInfoHosts.addrs,
"addrs": [item.addr for item in self.mockDataInfoHosts.addrs],
"cr_date": self.mockDataInfoHosts.cr_date,
}