zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-25 20:18:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

lint, change permissions tests in permissions classes

Browse source
This commit is contained in:
Rachid Mrad 2023-09-29 14:39:18 -04:00
parent ca327fc094
commit 2840ebc63d
No known key found for this signature in database
GPG key ID: EF38E4CEC4A8F3CF
3 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/registrar/migrations/0036_create_groups.py
View file

@ -12,6 +12,7 @@ from django.db import migrations
from registrar.models import UserGroup from registrar.models import UserGroup
from typing import Any from typing import Any
# For linting: RunPython expects a function reference, # For linting: RunPython expects a function reference,
# so let's give it one # so let's give it one
def create_groups(apps, schema_editor) -> Any: def create_groups(apps, schema_editor) -> Any:

6
src/registrar/views/utility/mixins.py
View file

@ -63,9 +63,9 @@ class DomainPermission(PermissionsLoginMixin):
""" """
# Check if the user is permissioned... # Check if the user is permissioned...
user_is_analyst_or_superuser = ( user_is_analyst_or_superuser = self.request.user.has_perm(
self.request.user.is_staff or self.request.user.is_superuser "registrar.analyst_access_permission"
) ) or self.request.user.has_perm("registrar.full_access_permission")
if not user_is_analyst_or_superuser: if not user_is_analyst_or_superuser:
return False return False

4
src/registrar/views/utility/permission_views.py
View file

@ -33,7 +33,9 @@ class DomainPermissionView(DomainPermission, DetailView, abc.ABC):
def get_context_data(self, **kwargs): def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs) context = super().get_context_data(**kwargs)
user = self.request.user user = self.request.user
context["is_analyst_or_superuser"] = user.is_staff or user.is_superuser context["is_analyst_or_superuser"] = user.has_perm(
"registrar.analyst_access_permission"
) or user.has_perm("registrar.full_access_permission")
# Stored in a variable for the linter # Stored in a variable for the linter
action = "analyst_action" action = "analyst_action"
action_location = "analyst_action_location" action_location = "analyst_action_location"