zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-14 13:34:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix linting

Browse source
This commit is contained in:
Erin 2024-01-17 15:00:42 -08:00
parent d68e82a130
commit 267ba51308
No known key found for this signature in database
GPG key ID: 1CAD275313C62460
2 changed files with 23 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/registrar/management/commands/disclose_security_emails.py
View file

@ -52,19 +52,19 @@ class Command(BaseCommand):
# Update EPP contact for domains with a security contact # Update EPP contact for domains with a security contact
for domain in domains: for domain in domains:
try: try:
logger.info(f"Domain {domain.domain_info} security contact: {domain.security_contact.email}") logger.info(f"Domain {domain.name} security contact: {domain.security_contact.email}")
if domain.security_contact.email != "registrar@dotgov.gov": if domain.security_contact.email != "registrar@dotgov.gov":
domain._update_epp_contact(contact=domain.security_contact) domain._update_epp_contact(contact=domain.security_contact)
self.disclosed_domain_contacts_count += 1 self.disclosed_domain_contacts_count += 1
else: else:
logger.info( logger.info(
f"Skipping disclose for {domain.domain_info} security contact {domain.security_contact.email}." f"Skipping disclose for {domain.name} security contact {domain.security_contact.email}."
) )
self.skipped_domain_contacts_count += 1 self.skipped_domain_contacts_count += 1
except Exception as err: except Exception as err:
# error condition if domain not in database # error condition if domain not in database
self.domains_with_errors.append(copy.deepcopy(domain.domain_info)) self.domains_with_errors.append(copy.deepcopy(domain.name))
logger.error(f"error retrieving domain {domain.domain_info} contact {domain.security_contact}: {err}") logger.error(f"error retrieving domain {domain.name} contact {domain.security_contact}: {err}")
# Inform user how many contacts were disclosed, skipped, and errored # Inform user how many contacts were disclosed, skipped, and errored
logger.info(f"Updated {self.disclosed_domain_contacts_count} contacts to disclosed.") logger.info(f"Updated {self.disclosed_domain_contacts_count} contacts to disclosed.")

23
src/registrar/tests/test_models_domain.py
View file

@ -983,16 +983,31 @@ class TestRegistrantContacts(MockEppLib):
Tests that command disclose_security_emails runs successfully with Tests that command disclose_security_emails runs successfully with
appropriate EPP calll to UpdateContact. appropriate EPP calll to UpdateContact.
""" """
domain, _ = Domain.objects.get_or_create(name="igorville.gov") domain, _ = Domain.objects.get_or_create(name="testdisclose.gov", state=Domain.State.READY)
expectedSecContact = PublicContact.get_default_security() expectedSecContact = PublicContact.get_default_security()
expectedSecContact.domain = domain expectedSecContact.domain = domain
expectedSecContact.email = "123@mail.gov" expectedSecContact.email = "123@mail.gov"
# set domain security email to 123@mail.gov instead of default email
domain.security_contact = expectedSecContact domain.security_contact = expectedSecContact
self.run_disclose_security_emails() self.run_disclose_security_emails()
# running disclose_security_emails makes EPP calls # running disclose_security_emails sends EPP call UpdateContact with disclose
expectedUpdateCommand = self._convertPublicContactToEpp(expectedSecContact, disclose_email=True) self.mockedSendFunction.assert_has_calls(
self.mockedSendFunction.assert_any_call(expectedUpdateCommand, cleaned=True) [
call(
commands.UpdateContact(
id=domain.security_contact.registry_id,
postal_info=domain._make_epp_contact_postal_info(contact=domain.security_contact),
email=domain.security_contact.email,
voice=domain.security_contact.voice,
fax=domain.security_contact.fax,
auth_info=common.ContactAuthInfo(pw="2fooBAR123fooBaz"),
disclose=domain._disclose_fields(contact=domain.security_contact),
),
cleaned=True,
)
]
)
@skip("not implemented yet") @skip("not implemented yet")
def test_update_is_unsuccessful(self): def test_update_is_unsuccessful(self):