zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-17 10:07:04 +02:00
Code Issues Projects Releases Packages Wiki Activity

Linting, unit tests

Browse source
This commit is contained in:
zandercymatics 2024-02-26 09:00:33 -07:00
parent 02e0d00544
commit 25a5cd0226
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
4 changed files with 18 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/tests/common.py
View file

@ -564,8 +564,8 @@ def completed_application(
investigator, _ = User.objects.get_or_create( investigator, _ = User.objects.get_or_create(
username="incrediblyfakeinvestigator", username="incrediblyfakeinvestigator",
first_name="Joe", first_name="Joe",
last_name = "Bob" last_name="Bob",
is_staff=True is_staff=True,
) )
domain_application_kwargs = dict( domain_application_kwargs = dict(
organization_type="federal", organization_type="federal",

16
src/registrar/utility/errors.py
View file

@ -70,6 +70,7 @@ class GenericError(Exception):
def get_error_message(self, code=None): def get_error_message(self, code=None):
return self._error_mapping.get(code) return self._error_mapping.get(code)
# (Q for reviewers) What should this be called? # (Q for reviewers) What should this be called?
# Not a fan of this name. # Not a fan of this name.
class FSMErrorCodes(IntEnum): class FSMErrorCodes(IntEnum):
@ -80,6 +81,7 @@ class FSMErrorCodes(IntEnum):
- 3 APPROVE_INVESTIGATOR_NOT_STAFF Investigator is a non-staff user - 3 APPROVE_INVESTIGATOR_NOT_STAFF Investigator is a non-staff user
- 4 APPROVE_INVESTIGATOR_NOT_SUBMITTER The form submitter is not the investigator - 4 APPROVE_INVESTIGATOR_NOT_SUBMITTER The form submitter is not the investigator
""" """
APPROVE_DOMAIN_IN_USE = 1 APPROVE_DOMAIN_IN_USE = 1
APPROVE_NO_INVESTIGATOR = 2 APPROVE_NO_INVESTIGATOR = 2
APPROVE_INVESTIGATOR_NOT_STAFF = 3 APPROVE_INVESTIGATOR_NOT_STAFF = 3
@ -95,18 +97,12 @@ class ApplicationStatusError(Exception):
""" """
_error_mapping = { _error_mapping = {
FSMErrorCodes.APPROVE_DOMAIN_IN_USE: ( FSMErrorCodes.APPROVE_DOMAIN_IN_USE: ("Cannot approve. Requested domain is already in use."),
"Cannot approve. Requested domain is already in use." FSMErrorCodes.APPROVE_NO_INVESTIGATOR: ("Cannot approve. No investigator was assigned."),
), FSMErrorCodes.APPROVE_INVESTIGATOR_NOT_STAFF: ("Cannot approve. Investigator is not a staff user."),
FSMErrorCodes.APPROVE_NO_INVESTIGATOR: (
"Cannot approve. No investigator was assigned."
),
FSMErrorCodes.APPROVE_INVESTIGATOR_NOT_STAFF: (
"Cannot approve. Investigator is not a staff user."
),
FSMErrorCodes.APPROVE_INVESTIGATOR_NOT_SUBMITTER: ( FSMErrorCodes.APPROVE_INVESTIGATOR_NOT_SUBMITTER: (
"Cannot approve. Only the assigned investigator can approve this application." "Cannot approve. Only the assigned investigator can approve this application."
) ),
} }
def __init__(self, *args, code=None, **kwargs): def __init__(self, *args, code=None, **kwargs):