zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-14 15:05:14 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix some tests + fix add view

Browse source
This commit is contained in:
zandercymatics 2024-09-26 11:05:58 -06:00
parent 75b34dab3b
commit 237d066233
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
3 changed files with 9 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/registrar/assets/js/get-gov-admin.js
View file

@ -891,14 +891,18 @@ function initializeWidgetOnList(list, parentId) {
}); });
function handleOrganizationTypeChange(organizationType, organizationNameContainer, federalType) { function handleOrganizationTypeChange(organizationType, organizationNameContainer, federalType) {
if (organizationType && organizationNameContainer && federalType) { if (organizationType && organizationNameContainer) {
let selectedValue = organizationType.value; let selectedValue = organizationType.value;
if (selectedValue === "federal") { if (selectedValue === "federal") {
hideElement(organizationNameContainer); hideElement(organizationNameContainer);
showElement(federalType); if (federalType) {
showElement(federalType);
}
} else { } else {
showElement(organizationNameContainer); showElement(organizationNameContainer);
hideElement(federalType); if (federalType) {
hideElement(federalType);
}
} }
} }
} }

13
src/registrar/tests/test_admin.py
View file

@ -2097,17 +2097,8 @@ class TestPortfolioAdmin(TestCase):
) )
display_admins = self.admin.display_admins(self.portfolio) display_admins = self.admin.display_admins(self.portfolio)
url = reverse("admin:registrar_userportfoliopermission_changelist") + f"?portfolio={self.portfolio.id}"
url = reverse("admin:registrar_userportfoliopermission_change", args=[perm_1.pk]) self.assertIn(f'<a href="{url}">2 administrators</a>', display_admins)
self.assertIn(
f'<a href="{url}">Gerald Meoward meaoward@gov.gov</a>',
display_admins,
)
self.assertIn("Captain", display_admins)
url = reverse("admin:registrar_userportfoliopermission_change", args=[perm_2.pk])
self.assertIn(f'<a href="{url}">Arnold Poopy poopy@gov.gov</a>', display_admins)
self.assertIn("Major", display_admins)
display_members_summary = self.admin.display_members_summary(self.portfolio) display_members_summary = self.admin.display_members_summary(self.portfolio)

1
src/registrar/tests/test_api.py
View file

@ -100,7 +100,6 @@ class GetFederalPortfolioTypeJsonTest(TestCase):
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
data = response.json() data = response.json()
self.assertEqual(data["federal_type"], "Judicial") self.assertEqual(data["federal_type"], "Judicial")
self.assertEqual(data["portfolio_type"], "Federal - Judicial")
@less_console_noise_decorator @less_console_noise_decorator
def test_get_federal_and_portfolio_types_json_authenticated_regularuser(self): def test_get_federal_and_portfolio_types_json_authenticated_regularuser(self):