zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-21 00:34:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

review changes

Browse source
This commit is contained in:
Matthew Spence 2024-12-13 15:23:15 -06:00
parent 63c2b7907f
commit 21007ce869
No known key found for this signature in database
3 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/registrar/models/domain.py
View file

@ -750,7 +750,12 @@ class Domain(TimeStampedModel, DomainHelper):
successTotalNameservers = len(oldNameservers) - deleteCount + addToDomainCount
self._delete_hosts_if_not_used(hostsToDelete=deleted_values)
try:
self._delete_hosts_if_not_used(hostsToDelete=deleted_values)
except:
# the error will be logged in the erring function and we don't
# need this part to succeed in order to continue.s
pass
if successTotalNameservers < 2:
try:
@ -1065,6 +1070,8 @@ class Domain(TimeStampedModel, DomainHelper):
if responseCode != ErrorCode.COMMAND_COMPLETED_SUCCESSFULLY:
raise NameserverError(code=nsErrorCodes.BAD_DATA)
# addAndRemoveHostsFromDomain removes the hosts from the domain object,
# but we still need to delete the object themselves
self._delete_hosts_if_not_used(hostsToDelete=deleted_values)
logger.debug("Deleting non-registrant contacts for %s", self.name)