zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-08-23 17:51:03 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add test for race condition

Browse source
This commit is contained in:
zandercymatics 2025-01-16 15:15:36 -07:00
parent 511e9610e2
commit 1ece895ac6
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 64 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/registrar/models/domain.py
View file

@ -1939,6 +1939,8 @@ class Domain(TimeStampedModel, DomainHelper):
Additionally, capture and cache old hosts and contacts from cache if they
don't exist in cleaned
"""
# object reference issue between self._cache vs cleaned?
old_cache_hosts = self._cache.get("hosts")
old_cache_contacts = self._cache.get("contacts")
@ -2111,19 +2113,20 @@ class Domain(TimeStampedModel, DomainHelper):
# Save to DB if it doesn't exist already.
if db_contact.count() == 0:
# Doesn't run custom save logic, just saves to DB
try:
public_contact.save(skip_epp_save=True)
logger.info(f"Created a new PublicContact: {public_contact}")
except IntegrityError as err:
logger.error(
"_get_or_create_public_contact() => tried to create a duplicate public contact: "
f"{err}", exc_info=True
)
return PublicContact.objects.get(
registry_id=public_contact.registry_id,
contact_type=public_contact.contact_type,
domain=self,
)
public_contact.save(skip_epp_save=True)
# try:
# public_contact.save(skip_epp_save=True)
# logger.info(f"Created a new PublicContact: {public_contact}")
# except IntegrityError as err:
# logger.error(
# "_get_or_create_public_contact() => tried to create a duplicate public contact: "
# f"{err}", exc_info=True
# )
# return PublicContact.objects.get(
# registry_id=public_contact.registry_id,
# contact_type=public_contact.contact_type,
# domain=self,
# )
# Append the item we just created
return public_contact