zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-25 12:08:40 +02:00
Code Issues Projects Releases Packages Wiki Activity

Resond to PR feedback

Browse source
This commit is contained in:
Seamus Johnston 2023-06-01 11:27:38 -05:00
parent 5b78b0ec67
commit 1cd74ebda5
No known key found for this signature in database
GPG key ID: 2F21225985069105
2 changed files with 19 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/registrar/models/domain.py
View file

@ -1,6 +1,7 @@
import logging
from datetime import date
from django_fsm import FSMField # type: ignore
from django.db import models
@ -125,7 +126,8 @@ class Domain(TimeStampedModel, DomainHelper):
IDs are provided as strings, e.g.
{"registrant": "jd1234", "admin": "sh8013",...}
{ PublicContact.ContactTypeChoices.REGISTRANT: "jd1234",
PublicContact.ContactTypeChoices.ADMINISTRATIVE: "sh8013",...}
"""
raise NotImplementedError()
@ -155,7 +157,14 @@ class Domain(TimeStampedModel, DomainHelper):
@property
def password(self) -> str:
"""Get the `auth_info.pw` element from the registry. Not a real password."""
"""
Get the `auth_info.pw` element from the registry. Not a real password.
This `auth_info` element is required by the EPP protocol, but the registry is
using a different mechanism to ensure unauthorized clients cannot perform
actions on domains they do not own. This field provides no security features.
It is not a secret.
"""
raise NotImplementedError()
@property
@ -275,10 +284,11 @@ class Domain(TimeStampedModel, DomainHelper):
help_text="Fully qualified domain name",
)
state = models.CharField(
state = FSMField(
max_length=21,
choices=State.choices,
default=State.UNKNOWN,
protected=True, # cannot change state directly, particularly in Django admin
help_text="Very basic info about the lifecycle of this domain object",
)