From 1a3c095e0bcfbcc6f4ec588ea08113bed535d994 Mon Sep 17 00:00:00 2001 From: CocoByte Date: Thu, 19 Oct 2023 23:41:19 -0600 Subject: [PATCH] linted Signed-off-by: CocoByte --- src/registrar/models/user.py | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/registrar/models/user.py b/src/registrar/models/user.py index e2fff98b8..7207a5a61 100644 --- a/src/registrar/models/user.py +++ b/src/registrar/models/user.py @@ -87,19 +87,23 @@ class User(AbstractUser): transition_domain_status = transition_domain.status transition_domain_email = transition_domain.username - new_domain = Domain(name=transition_domain_name, state=transition_domain_status) - new_domain.save() - # check that a domain invitation doesn't already - # exist for this e-mail / Domain pair - domain_email_already_in_domain_invites = DomainInvitation.objects.filter( - email=transition_domain_email.lower(), domain=new_domain - ).exists() - if not domain_email_already_in_domain_invites: - # Create new domain invitation - new_domain_invitation = DomainInvitation( - email=transition_domain_email.lower(), domain=new_domain + # type safety check. name should never be none + if transition_domain_name is not None: + new_domain = Domain( + name=transition_domain_name, state=transition_domain_status ) - new_domain_invitation.save() + new_domain.save() + # check that a domain invitation doesn't already + # exist for this e-mail / Domain pair + domain_email_already_in_domain_invites = DomainInvitation.objects.filter( + email=transition_domain_email.lower(), domain=new_domain + ).exists() + if not domain_email_already_in_domain_invites: + # Create new domain invitation + new_domain_invitation = DomainInvitation( + email=transition_domain_email.lower(), domain=new_domain + ) + new_domain_invitation.save() def check_transition_domains_on_login(self): """When a user first arrives on the site, we need to check