From 192658c87ff3feac0017ad4ed7789668422e32ed Mon Sep 17 00:00:00 2001 From: Erin Song <121973038+erinysong@users.noreply.github.com> Date: Thu, 17 Oct 2024 14:47:05 -0700 Subject: [PATCH] Readd design checks --- .github/pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 102892b98..d9de6e14a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -80,12 +80,13 @@ Resolves #00 #### Verified that the changes match the design intention - [ ] Checked that the design translated visually +- [ ] Checked different states (empty, one, some, error) +- [ ] Checked for landmarks, page heading structure, and links - [ ] Checked behavior. Comment any found issues or broken flows. #### Validated user-facing changes as a designer - [ ] Checked keyboard navigability -- [ ] Checked different states (empty, one, some, error) - [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI) - [ ] Tested with multiple browsers (check off which ones were used) - [ ] Chrome