zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-19 02:49:21 +02:00
Code Issues Projects Releases Packages Wiki Activity

Update availability tests

Browse source
This commit is contained in:
Erin 2023-11-29 16:39:03 -08:00
parent 69dd932320
commit 18ae412d0e
No known key found for this signature in database
GPG key ID: 1CAD275313C62460
2 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/api/tests/test_available.py
View file

@ -101,15 +101,17 @@ class AvailableViewTest(MockEppLib):
self.assertTrue(json.loads(response.content)["available"])
def test_error_handling(self):
"""Calling with bad strings raises an error."""
"""Calling with bad strings returns error (error verifying) or unavailable (invalid domain)."""
bad_string = "blah!;"
request = self.factory.get(API_BASE_PATH + bad_string)
request.user = self.user
response = available(request, domain=bad_string)
self.assertFalse(json.loads(response.content)["available"])
# domain set to raise error returns false for availability
error_domain_available = available(request, "errordomain.gov")
self.assertRaises(json.loads(error_domain_available.content)["available"])
# domain set to raise error returns false for availability and error message
error_domain_response = available(request, domain="errordomain.gov")
self.assertFalse(json.loads(error_domain_response.content)["available"])
self.assertIn("Error finding domain availability",
json.loads(error_domain_response.content)["message"])
class AvailableAPITest(MockEppLib):

6
src/api/views.py
View file

@ -30,8 +30,8 @@ DOMAIN_API_MESSAGES = {
),
"invalid": "Enter a domain using only letters, numbers, or hyphens (though we don't recommend using hyphens).",
"success": "That domain is available!",
"error": "Error finding domain availability. Please wait a few minutes and try again. If you continue \
to receive this error after a few tries, contact help@get.gov",
"error": "Error finding domain availability. Please wait a few minutes and try again.\
If you continue to receive this error after a few tries, contact help@get.gov",
}
@ -74,7 +74,7 @@ def check_domain_available(domain):
# domain search string doesn't end with .gov, add it on here
return Domain.available(domain + ".gov")
except Exception as err:
return err
raise err
@require_http_methods(["GET"])