zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-06-14 16:34:49 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add better error messages

Browse source
This commit is contained in:
zandercymatics 2023-11-13 08:16:51 -07:00
parent 6f528e8330
commit 1890cc8f26
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 27 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/registrar/management/commands/load_transition_domain.py
View file

@ -1,4 +1,5 @@
import json
import os
import sys
import csv
import logging
@ -426,6 +427,22 @@ class Command(BaseCommand):
# print message to terminal about which args are in use
self.print_debug_mode_statements(debug_on, debug_max_entries_to_parse)
filenames = [
agency_adhoc_filename,
domain_adhoc_filename,
organization_adhoc_filename,
domain_escrow_filename,
domain_additional_filename,
]
# Do a top-level check to see if these files exist
for filename in filenames:
if not isinstance(filename, str):
raise TypeError(f"Filename must be a string, got {type(filename).__name__}")
full_path = os.path.join(directory, filename)
if not os.path.isfile(full_path):
raise FileNotFoundError(full_path)
# STEP 1:
# Create mapping of domain name -> status
domain_status_dictionary = self.get_domain_user_dict(

14
src/registrar/management/commands/utility/extra_transition_domain_helper.py
View file

@ -867,8 +867,11 @@ class ExtraTransitionDomain:
)
else:
if not infer_filenames:
logger.error(f"Could not find file: {filename}")
continue
raise FileNotFoundError(
f"{TerminalColors.FAIL}"
f"Could not find file {filename} for {name}"
f"{TerminalColors.ENDC}"
)
# Infer filename logic #
# This mode is used for
@ -899,8 +902,11 @@ class ExtraTransitionDomain:
is_domain_escrow,
)
continue
# Log if we can't find the desired file
logger.error(f"Could not find file: {filename}")
raise FileNotFoundError(
f"{TerminalColors.FAIL}"
f"Could not find file {filename} for {name}"
f"{TerminalColors.ENDC}"
)
def clear_file_data(self):
for item in self.file_data.values():