Merge pull request #1844 from cisagov/za/1840-staging-hotfix-csv-report

(Based off of Staging) Ticket #1840: Hotfix for csv_export only populating 1 thousand records
This commit is contained in:
zandercymatics 2024-02-29 15:38:18 -07:00 committed by GitHub
commit 15fab5bd13
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -167,9 +167,12 @@ def write_csv(
max_dm_count = max(len(domain_info.domain.permissions.all()) for domain_info in all_domain_infos)
update_columns_with_domain_managers(columns, max_dm_count)
if should_write_header:
write_header(writer, columns)
for page_num in paginator.page_range:
page = paginator.page(page_num)
rows = []
page = paginator.page(page_num)
for domain_info in page.object_list:
try:
row = parse_row(columns, domain_info, security_emails_dict, get_domain_managers)
@ -180,10 +183,7 @@ def write_csv(
logger.error("csv_export -> Error when parsing row, domain was None")
continue
if should_write_header:
write_header(writer, columns)
writer.writerows(rows)
writer.writerows(rows)
def export_data_type_to_csv(csv_file):