zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-27 21:16:28 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix remaining tests

Browse source
This commit is contained in:
zandercymatics 2024-10-02 11:57:30 -06:00
parent 2766202952
commit 14241976fc
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 15 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/registrar/tests/test_admin_request.py
View file

@ -1637,6 +1637,7 @@ class TestDomainRequestAdmin(MockEppLib):
"updated_at", "updated_at",
"status", "status",
"rejection_reason", "rejection_reason",
"rejection_reason_email",
"action_needed_reason", "action_needed_reason",
"action_needed_reason_email", "action_needed_reason_email",
"federal_agency", "federal_agency",

28
src/registrar/tests/test_api.py
View file

@ -144,8 +144,8 @@ class GetActionNeededEmailForUserJsonTest(TestCase):
) )
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
data = response.json() data = response.json()
self.assertIn("action_needed_email", data) self.assertIn("email", data)
self.assertIn("ORGANIZATION MAY NOT MEET ELIGIBILITY REQUIREMENTS", data["action_needed_email"]) self.assertIn("ORGANIZATION MAY NOT MEET ELIGIBILITY REQUIREMENTS", data["email"])
@less_console_noise_decorator @less_console_noise_decorator
def test_get_action_needed_email_for_user_json_analyst(self): def test_get_action_needed_email_for_user_json_analyst(self):
@ -161,8 +161,8 @@ class GetActionNeededEmailForUserJsonTest(TestCase):
) )
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
data = response.json() data = response.json()
self.assertIn("action_needed_email", data) self.assertIn("email", data)
self.assertIn("SENIOR OFFICIAL DOES NOT MEET ELIGIBILITY REQUIREMENTS", data["action_needed_email"]) self.assertIn("SENIOR OFFICIAL DOES NOT MEET ELIGIBILITY REQUIREMENTS", data["email"])
@less_console_noise_decorator @less_console_noise_decorator
def test_get_action_needed_email_for_user_json_regular(self): def test_get_action_needed_email_for_user_json_regular(self):
@ -188,10 +188,10 @@ class GetRejectionEmailForUserJsonTest(TestCase):
self.domain_request = completed_domain_request( self.domain_request = completed_domain_request(
federal_agency=self.agency, federal_agency=self.agency,
name="test.gov", name="test.gov",
status=DomainRequest.DomainRequestStatus.ACTION_NEEDED, status=DomainRequest.DomainRequestStatus.REJECTED,
) )
self.api_url = reverse("get-action-needed-email-for-user-json") self.api_url = reverse("get-rejection-email-for-user-json")
def tearDown(self): def tearDown(self):
DomainRequest.objects.all().delete() DomainRequest.objects.all().delete()
@ -199,21 +199,21 @@ class GetRejectionEmailForUserJsonTest(TestCase):
FederalAgency.objects.all().delete() FederalAgency.objects.all().delete()
@less_console_noise_decorator @less_console_noise_decorator
def test_get_action_needed_email_for_user_json_superuser(self): def test_get_rejected_email_for_user_json_superuser(self):
"""Test that a superuser can fetch the action needed email.""" """Test that a superuser can fetch the action needed email."""
self.client.force_login(self.superuser) self.client.force_login(self.superuser)
response = self.client.get( response = self.client.get(
self.api_url, self.api_url,
{ {
"reason": DomainRequest.ActionNeededReasons.ELIGIBILITY_UNCLEAR, "reason": DomainRequest.RejectionReasons.CONTACTS_NOT_VERIFIED,
"domain_request_id": self.domain_request.id, "domain_request_id": self.domain_request.id,
}, },
) )
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
data = response.json() data = response.json()
self.assertIn("action_needed_email", data) self.assertIn("email", data)
self.assertIn("ORGANIZATION MAY NOT MEET ELIGIBILITY REQUIREMENTS", data["action_needed_email"]) self.assertIn("we could not verify the organizational", data["email"])
@less_console_noise_decorator @less_console_noise_decorator
def test_get_action_needed_email_for_user_json_analyst(self): def test_get_action_needed_email_for_user_json_analyst(self):
@ -223,14 +223,14 @@ class GetRejectionEmailForUserJsonTest(TestCase):
response = self.client.get( response = self.client.get(
self.api_url, self.api_url,
{ {
"reason": DomainRequest.ActionNeededReasons.QUESTIONABLE_SENIOR_OFFICIAL, "reason": DomainRequest.RejectionReasons.CONTACTS_NOT_VERIFIED,
"domain_request_id": self.domain_request.id, "domain_request_id": self.domain_request.id,
}, },
) )
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
data = response.json() data = response.json()
self.assertIn("action_needed_email", data) self.assertIn("email", data)
self.assertIn("SENIOR OFFICIAL DOES NOT MEET ELIGIBILITY REQUIREMENTS", data["action_needed_email"]) self.assertIn("we could not verify the organizational", data["email"])
@less_console_noise_decorator @less_console_noise_decorator
def test_get_action_needed_email_for_user_json_regular(self): def test_get_action_needed_email_for_user_json_regular(self):
@ -240,7 +240,7 @@ class GetRejectionEmailForUserJsonTest(TestCase):
response = self.client.get( response = self.client.get(
self.api_url, self.api_url,
{ {
"reason": DomainRequest.ActionNeededReasons.QUESTIONABLE_SENIOR_OFFICIAL, "reason": DomainRequest.RejectionReasons.CONTACTS_NOT_VERIFIED,
"domain_request_id": self.domain_request.id, "domain_request_id": self.domain_request.id,
}, },
) )