diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index ec2c92824..ff7dcbfd0 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -1307,15 +1307,17 @@ class Domain(TimeStampedModel, DomainHelper): choices.TECHNICAL: None, } registrant_id = ... - existing_contacts = PublicContact.objects.filter( - domain=self - ) + existing_contacts = PublicContact.objects.filter(domain=self) if existing_contacts.count() > 0: for choice in contacts_dict: - contacts_dict[choice] = existing_contacts.get(contact_type=choice).registry_id + contacts_dict[choice] = existing_contacts.get( + contact_type=choice + ).registry_id # Edge case for registrant registrant = PublicContact.ContactTypeChoices.REGISTRANT - registrant_id = existing_contacts.get(contact_type=registrant).registry_id + registrant_id = existing_contacts.get( + contact_type=registrant + ).registry_id cache = { "auth_info": getattr(data, "auth_info", ...), @@ -1324,7 +1326,7 @@ class Domain(TimeStampedModel, DomainHelper): "ex_date": getattr(data, "ex_date", ...), "hosts": getattr(data, "hosts", ...), "name": getattr(data, "name", self.name), - "registrant": getattr(data, "name", registrant_id), + "registrant": getattr(data, "name", registrant_id), "statuses": getattr(data, "statuses", ...), "tr_date": getattr(data, "tr_date", ...), "up_date": getattr(data, "up_date", ...), @@ -1333,9 +1335,9 @@ class Domain(TimeStampedModel, DomainHelper): self._cache = cleaned else: + logger.error("Unknown TransitionNotAllowed exception") raise err - def _get_or_create_public_contact(self, public_contact: PublicContact): """Tries to find a PublicContact object in our DB. If it can't, it'll create it. Returns PublicContact""" diff --git a/src/registrar/views/domain.py b/src/registrar/views/domain.py index f30014269..710e76e6b 100644 --- a/src/registrar/views/domain.py +++ b/src/registrar/views/domain.py @@ -310,9 +310,7 @@ class DomainSecurityEmailView(DomainPermissionView, FormMixin): # If no default is created for security_contact, # then we cannot connect to EPPLib. if contact is None: - messages.error( - self.request, "Update failed. Cannot contact the registry." - ) + messages.error(self.request, "Update failed. Cannot contact the registry.") return redirect(self.get_success_url()) contact.email = new_email