zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-06 11:13:21 +02:00
Code Issues Projects Releases Packages Wiki Activity

Address feedback

Browse source
This commit is contained in:
Rebecca Hsieh 2024-04-26 13:14:11 -07:00
parent 4021b8a66c
commit 11f8081c5b
No known key found for this signature in database
2 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/registrar/management/commands/populate_domain_updated_federal_agency.py
View file

@ -41,7 +41,7 @@ class Command(BaseCommand):
Renames the Federal Agency to the correct new naming Renames the Federal Agency to the correct new naming
for both Domain Information and Domain Requests objects. for both Domain Information and Domain Requests objects.
NOTE: If it's NULL for a domain request, we skip it as NOTE: If it's None for a domain request, we skip it as
a user most likely hasn't gotten to it yet. a user most likely hasn't gotten to it yet.
""" """
logger.info("Transferring federal agencies to FederalAgency object") logger.info("Transferring federal agencies to FederalAgency object")
@ -65,7 +65,7 @@ class Command(BaseCommand):
domain_info.updated_federal_agency = federal_agency_row domain_info.updated_federal_agency = federal_agency_row
domain_infos_to_update.append(domain_info) domain_infos_to_update.append(domain_info)
logger.info( logger.info(
f"DomainInformation {domain_info} updated_federal_agency set to:" f"DomainInformation {domain_info} => updated_federal_agency set to:"
f"{domain_info.updated_federal_agency}" f"{domain_info.updated_federal_agency}"
) )
except Exception as err: except Exception as err:
@ -83,7 +83,7 @@ class Command(BaseCommand):
domain_request.updated_federal_agency = federal_agency_row domain_request.updated_federal_agency = federal_agency_row
domain_requests_to_update.append(domain_request) domain_requests_to_update.append(domain_request)
logger.info( logger.info(
f"DomainRequest {domain_request} updated_federal_agency set to:" f"DomainRequest {domain_request} => updated_federal_agency set to:"
f"{domain_request.updated_federal_agency}" f"{domain_request.updated_federal_agency}"
) )
except Exception as err: except Exception as err:

8
src/registrar/tests/test_management_scripts.py
View file

@ -746,7 +746,7 @@ class TestDiscloseEmails(MockEppLib):
# TODO in #1793: Remove this whole test class # TODO in #1793: Remove this whole test class
class TestRenamingFederalAgency(TestCase): class TestPopulateDomainUpdatedFederalAgency(TestCase):
def setUp(self): def setUp(self):
super().setUp() super().setUp()
@ -802,11 +802,7 @@ class TestRenamingFederalAgency(TestCase):
execute the populate_domain_updated_federal_agency command. execute the populate_domain_updated_federal_agency command.
""" """
with less_console_noise(): with less_console_noise():
with patch( call_command("populate_domain_updated_federal_agency")
"registrar.management.commands.utility.terminal_helper.TerminalHelper.query_yes_no_exit", # noqa
return_value=True,
):
call_command("populate_domain_updated_federal_agency")
def test_domain_information_renaming_federal_agency_success(self): def test_domain_information_renaming_federal_agency_success(self):
""" """