+
+
+ + +
+Members
diff --git a/src/registrar/templates/profile.html b/src/registrar/templates/profile.html index 6e1e7781f..7d365d9c1 100644 --- a/src/registrar/templates/profile.html +++ b/src/registrar/templates/profile.html @@ -51,11 +51,11 @@ Edit your User Profile | >
-
+
+
Add contact information
-
+
.Gov domain registrants must maintain accurate contact information in the .gov registrar.
Before you can manage your domain, we need you to add your contact information.
diff --git a/src/registrar/tests/test_models.py b/src/registrar/tests/test_models.py
index 53206359b..0c1bdec2a 100644
--- a/src/registrar/tests/test_models.py
+++ b/src/registrar/tests/test_models.py
@@ -824,6 +824,92 @@ class TestUser(TestCase):
cm.exception.message, "When portfolio roles or additional permissions are assigned, portfolio is required."
)
+ @less_console_noise_decorator
+ def test_get_active_requests_count_in_portfolio_returns_zero_if_no_portfolio(self):
+ # There is no portfolio referenced in session so should return 0
+ request = self.factory.get("/")
+ request.session = {}
+
+ count = self.user.get_active_requests_count_in_portfolio(request)
+ self.assertEqual(count, 0)
+
+ @less_console_noise_decorator
+ def test_get_active_requests_count_in_portfolio_returns_count_if_portfolio(self):
+ request = self.factory.get("/")
+ request.session = {"portfolio": self.portfolio}
+
+ # Create active requests
+ domain_1, _ = DraftDomain.objects.get_or_create(name="meoward1.gov")
+ domain_2, _ = DraftDomain.objects.get_or_create(name="meoward2.gov")
+ domain_3, _ = DraftDomain.objects.get_or_create(name="meoward3.gov")
+ domain_4, _ = DraftDomain.objects.get_or_create(name="meoward4.gov")
+
+ # Create 3 active requests + 1 that isn't
+ DomainRequest.objects.create(
+ creator=self.user,
+ requested_domain=domain_1,
+ status=DomainRequest.DomainRequestStatus.SUBMITTED,
+ portfolio=self.portfolio,
+ )
+ DomainRequest.objects.create(
+ creator=self.user,
+ requested_domain=domain_2,
+ status=DomainRequest.DomainRequestStatus.IN_REVIEW,
+ portfolio=self.portfolio,
+ )
+ DomainRequest.objects.create(
+ creator=self.user,
+ requested_domain=domain_3,
+ status=DomainRequest.DomainRequestStatus.ACTION_NEEDED,
+ portfolio=self.portfolio,
+ )
+ DomainRequest.objects.create( # This one should not be counted
+ creator=self.user,
+ requested_domain=domain_4,
+ status=DomainRequest.DomainRequestStatus.REJECTED,
+ portfolio=self.portfolio,
+ )
+
+ count = self.user.get_active_requests_count_in_portfolio(request)
+ self.assertEqual(count, 3)
+
+ @less_console_noise_decorator
+ def test_is_only_admin_of_portfolio_returns_true(self):
+ # Create user as the only admin of the portfolio
+ UserPortfolioPermission.objects.create(
+ user=self.user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN]
+ )
+ self.assertTrue(self.user.is_only_admin_of_portfolio(self.portfolio))
+
+ @less_console_noise_decorator
+ def test_is_only_admin_of_portfolio_returns_false_if_no_admins(self):
+ # No admin for the portfolio
+ self.assertFalse(self.user.is_only_admin_of_portfolio(self.portfolio))
+
+ @less_console_noise_decorator
+ def test_is_only_admin_of_portfolio_returns_false_if_multiple_admins(self):
+ # Create multiple admins for the same portfolio
+ UserPortfolioPermission.objects.create(
+ user=self.user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN]
+ )
+ # Create another user within this test
+ other_user = User.objects.create(email="second_admin@igorville.gov", username="second_admin")
+ UserPortfolioPermission.objects.create(
+ user=other_user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN]
+ )
+ self.assertFalse(self.user.is_only_admin_of_portfolio(self.portfolio))
+
+ @less_console_noise_decorator
+ def test_is_only_admin_of_portfolio_returns_false_if_user_not_admin(self):
+ # Create other_user for same portfolio and is given admin access
+ other_user = User.objects.create(email="second_admin@igorville.gov", username="second_admin")
+
+ UserPortfolioPermission.objects.create(
+ user=other_user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN]
+ )
+ # User doesn't have admin access so should return false
+ self.assertFalse(self.user.is_only_admin_of_portfolio(self.portfolio))
+
class TestContact(TestCase):
@less_console_noise_decorator
diff --git a/src/registrar/tests/test_views_portfolio.py b/src/registrar/tests/test_views_portfolio.py
index a50a78b23..b7f455936 100644
--- a/src/registrar/tests/test_views_portfolio.py
+++ b/src/registrar/tests/test_views_portfolio.py
@@ -2,8 +2,9 @@ from django.urls import reverse
from api.tests.common import less_console_noise_decorator
from registrar.config import settings
from registrar.models import Portfolio, SeniorOfficial
-from unittest.mock import MagicMock
+from unittest.mock import MagicMock, patch
from django_webtest import WebTest # type: ignore
+from django.core.handlers.wsgi import WSGIRequest
from registrar.models import (
DomainRequest,
Domain,
@@ -959,7 +960,7 @@ class TestPortfolio(WebTest):
)
# Assert buttons and links within the page are correct
- self.assertContains(response, "usa-button--more-actions") # test that 3 dot is present
+ self.assertContains(response, "wrapper-delete-action") # test that 3 dot is present
self.assertContains(response, "sprite.svg#edit") # test that Edit link is present
self.assertContains(response, "sprite.svg#settings") # test that Manage link is present
self.assertNotContains(response, "sprite.svg#visibility") # test that View link is not present
@@ -1077,9 +1078,8 @@ class TestPortfolio(WebTest):
self.assertContains(
response, 'This member does not manage any domains. To assign this member a domain, click "Manage"'
)
-
# Assert buttons and links within the page are correct
- self.assertContains(response, "usa-button--more-actions") # test that 3 dot is present
+ self.assertContains(response, "wrapper-delete-action") # test that 3 dot is present
self.assertContains(response, "sprite.svg#edit") # test that Edit link is present
self.assertContains(response, "sprite.svg#settings") # test that Manage link is present
self.assertNotContains(response, "sprite.svg#visibility") # test that View link is not present
@@ -1392,6 +1392,510 @@ class TestPortfolio(WebTest):
self.assertTrue(DomainRequest.objects.filter(pk=domain_request.pk).exists())
domain_request.delete()
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_members_table_contains_hidden_permissions_js_hook(self):
+ # In the members_table.html we use data-has-edit-permission as a boolean
+ # to indicate if a user has permission to edit members in the specific portfolio
+
+ # 1. User w/ edit permission
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # Create a member under same portfolio
+ member_email = "a_member@example.com"
+ member, _ = User.objects.get_or_create(username="a_member", email=member_email)
+
+ UserPortfolioPermission.objects.get_or_create(
+ user=member,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ )
+
+ # I log in as the User so I can see the Members Table
+ self.client.force_login(self.user)
+
+ # Specifically go to the Member Table page
+ response = self.client.get(reverse("members"))
+
+ self.assertContains(response, 'data-has-edit-permission="True"')
+
+ # 2. User w/o edit permission (additional permission of EDIT_MEMBERS removed)
+ permission = UserPortfolioPermission.objects.get(user=self.user, portfolio=self.portfolio)
+
+ # Remove the EDIT_MEMBERS additional permission
+ permission.additional_permissions = [
+ perm for perm in permission.additional_permissions if perm != UserPortfolioPermissionChoices.EDIT_MEMBERS
+ ]
+
+ # Save the updated permissions list
+ permission.save()
+
+ # Re-fetch the page to check for updated permissions
+ response = self.client.get(reverse("members"))
+
+ self.assertContains(response, 'data-has-edit-permission="False"')
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_member_page_has_kebab_wrapper_for_member_if_user_has_edit_permission(self):
+ """Test that the kebab wrapper displays for a member with edit permissions"""
+
+ # I'm a user
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # Create a member under same portfolio
+ member_email = "a_member@example.com"
+ member, _ = User.objects.get_or_create(username="a_member", email=member_email)
+
+ upp, _ = UserPortfolioPermission.objects.get_or_create(
+ user=member,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ )
+
+ # I log in as the User so I can see the Manage Member page
+ self.client.force_login(self.user)
+
+ # Specifically go to the Manage Member page
+ response = self.client.get(reverse("member", args=[upp.id]), follow=True)
+
+ self.assertEqual(response.status_code, 200)
+
+ # Check for email AND member type (which here is just member)
+ self.assertContains(response, f'data-member-name="{member_email}"')
+ self.assertContains(response, 'data-member-type="member"')
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_member_page_has_kebab_wrapper_for_invited_member_if_user_has_edit_permission(self):
+ """Test that the kebab wrapper displays for an invitedmember with edit permissions"""
+
+ # I'm a user
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # Invite a member under same portfolio
+ invited_member_email = "invited_member@example.com"
+ invitation = PortfolioInvitation.objects.create(
+ email=invited_member_email,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ )
+
+ # I log in as the User so I can see the Manage Member page
+ self.client.force_login(self.user)
+ response = self.client.get(reverse("invitedmember", args=[invitation.id]), follow=True)
+
+ self.assertEqual(response.status_code, 200)
+
+ # Assert the invited members email + invitedmember type
+ self.assertContains(response, f'data-member-name="{invited_member_email}"')
+ self.assertContains(response, 'data-member-type="invitedmember"')
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_member_page_does_not_have_kebab_wrapper(self):
+ """Test that the kebab does not display."""
+
+ # I'm a user
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # That creates a member with only view access
+ member_email = "member_with_view_access@example.com"
+ member, _ = User.objects.get_or_create(username="test_member_with_view_access", email=member_email)
+
+ upp, _ = UserPortfolioPermission.objects.get_or_create(
+ user=member,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ ],
+ )
+
+ # I log in as the Member with only view permissions to evaluate the pages behaviour
+ # when viewed by someone who doesn't have edit perms
+ self.client.force_login(member)
+
+ # Go to the Manage Member page
+ response = self.client.get(reverse("member", args=[upp.id]), follow=True)
+
+ self.assertEqual(response.status_code, 200)
+
+ # Assert that the kebab edit options are unavailable
+ self.assertNotContains(response, 'data-member-type="member"')
+ self.assertNotContains(response, 'data-member-type="invitedmember"')
+ self.assertNotContains(response, f'data-member-name="{member_email}"')
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_member_page_has_correct_form_wrapper(self):
+ """Test that the manage members page the right form wrapper"""
+
+ # I'm a user
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # That creates a member
+ member_email = "a_member@example.com"
+ member, _ = User.objects.get_or_create(email=member_email)
+
+ upp, _ = UserPortfolioPermission.objects.get_or_create(
+ user=member,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ )
+
+ # Login as the User to see the Manage Member page
+ self.client.force_login(self.user)
+
+ # Specifically go to the Manage Member page
+ response = self.client.get(reverse("member", args=[upp.id]), follow=True)
+
+ # Check for a 200 response
+ self.assertEqual(response.status_code, 200)
+
+ # Check for form method + that its "post" and id "member-delete-form"
+ self.assertContains(response, "Contact the .gov team to remove them."
+ )
+
+ self.assertContains(response, expected_error_message, status_code=400)
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_portfolio_member_delete_view_members_table_only_admin(self):
+ """Error state w/ deleting a member that's the only admin on Members Table"""
+
+ # I'm a user with admin permission
+ admin_perm_user, _ = UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ with patch.object(User, "is_only_admin_of_portfolio", return_value=True):
+ self.client.force_login(self.user)
+ # We check X_REQUESTED_WITH bc those return JSON responses
+ response = self.client.post(
+ reverse("member-delete", kwargs={"pk": admin_perm_user.pk}), HTTP_X_REQUESTED_WITH="XMLHttpRequest"
+ )
+
+ self.assertEqual(response.status_code, 400)
+ expected_error_message = (
+ "There must be at least one admin in your organization. Give another member admin "
+ "permissions, make sure they log into the registrar, and then remove this member."
+ )
+ self.assertContains(response, expected_error_message, status_code=400)
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_portfolio_member_table_delete_view_success(self):
+ """Success state with deleting on Members Table page bc no active request AND not only admin"""
+
+ # I'm a user
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # Creating a member that can be deleted (see patch)
+ member_email = "deleteable_member@example.com"
+ member, _ = User.objects.get_or_create(email=member_email)
+
+ # Set up the member in the portfolio
+ upp, _ = UserPortfolioPermission.objects.get_or_create(
+ user=member,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ )
+
+ # And set that the member has no active requests AND it's not the only admin
+ with patch.object(User, "get_active_requests_count_in_portfolio", return_value=0), patch.object(
+ User, "is_only_admin_of_portfolio", return_value=False
+ ):
+
+ # Attempt to delete
+ self.client.force_login(self.user)
+ response = self.client.post(
+ # We check X_REQUESTED_WITH bc those return JSON responses
+ reverse("member-delete", kwargs={"pk": upp.pk}),
+ HTTP_X_REQUESTED_WITH="XMLHttpRequest",
+ )
+
+ # Check for a successful deletion
+ self.assertEqual(response.status_code, 200)
+
+ expected_success_message = f"You've removed {member.email} from the organization."
+ self.assertContains(response, expected_success_message, status_code=200)
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_portfolio_member_delete_view_manage_members_page_active_requests(self):
+ """Error state when deleting a member with active requests on the Manage Members page"""
+
+ # I'm an admin user
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # Create a member with active requests
+ member_email = "member_with_active_request@example.com"
+ member, _ = User.objects.get_or_create(email=member_email)
+
+ upp, _ = UserPortfolioPermission.objects.get_or_create(
+ user=member,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ )
+ with patch.object(User, "get_active_requests_count_in_portfolio", return_value=1):
+ with patch("django.contrib.messages.error") as mock_error:
+ self.client.force_login(self.user)
+ response = self.client.post(
+ reverse("member-delete", kwargs={"pk": upp.pk}),
+ )
+ # We don't want to do follow=True in response bc that does automatic redirection
+
+ # We want 302 bc indicates redirect
+ self.assertEqual(response.status_code, 302)
+
+ support_url = "https://get.gov/contact/"
+ expected_error_message = (
+ f"This member has an active domain request and can't be removed from the organization. "
+ f"Contact the .gov team to remove them."
+ )
+
+ args, kwargs = mock_error.call_args
+ # Check if first arg is a WSGIRequest, confirms request object passed correctly
+ # WSGIRequest protocol is basically the HTTPRequest but in Django form (ie POST '/member/1/delete')
+ self.assertIsInstance(args[0], WSGIRequest)
+ # Check that the error message matches the expected error message
+ self.assertEqual(args[1], expected_error_message)
+
+ # Location is used for a 3xx HTTP status code to indicate that the URL was redirected
+ # and then confirm that we're still on the Manage Members page
+ self.assertEqual(response.headers["Location"], reverse("member", kwargs={"pk": upp.pk}))
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_portfolio_member_delete_view_manage_members_page_only_admin(self):
+ """Error state when trying to delete the only admin on the Manage Members page"""
+
+ # Create an admin with admin user perms
+ admin_perm_user, _ = UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # Set them to be the only admin and attempt to delete
+ with patch.object(User, "is_only_admin_of_portfolio", return_value=True):
+ with patch("django.contrib.messages.error") as mock_error:
+ self.client.force_login(self.user)
+ response = self.client.post(
+ reverse("member-delete", kwargs={"pk": admin_perm_user.pk}),
+ )
+
+ self.assertEqual(response.status_code, 302)
+
+ expected_error_message = (
+ "There must be at least one admin in your organization. Give another member admin "
+ "permissions, make sure they log into the registrar, and then remove this member."
+ )
+
+ args, kwargs = mock_error.call_args
+ # Check if first arg is a WSGIRequest, confirms request object passed correctly
+ # WSGIRequest protocol is basically the HTTPRequest but in Django form (ie POST '/member/1/delete')
+ self.assertIsInstance(args[0], WSGIRequest)
+ # Check that the error message matches the expected error message
+ self.assertEqual(args[1], expected_error_message)
+
+ # Location is used for a 3xx HTTP status code to indicate that the URL was redirected
+ # and then confirm that we're still on the Manage Members page
+ self.assertEqual(response.headers["Location"], reverse("member", kwargs={"pk": admin_perm_user.pk}))
+
+ @less_console_noise_decorator
+ @override_flag("organization_feature", active=True)
+ @override_flag("organization_members", active=True)
+ def test_portfolio_member_delete_view_manage_members_page_invitedmember(self):
+ """Success state w/ deleting invited member on Manage Members page should redirect back to Members Table"""
+
+ # I'm a user
+ UserPortfolioPermission.objects.get_or_create(
+ user=self.user,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
+ additional_permissions=[
+ UserPortfolioPermissionChoices.VIEW_MEMBERS,
+ UserPortfolioPermissionChoices.EDIT_MEMBERS,
+ ],
+ )
+
+ # Invite a member under same portfolio
+ invited_member_email = "invited_member@example.com"
+ invitation = PortfolioInvitation.objects.create(
+ email=invited_member_email,
+ portfolio=self.portfolio,
+ roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER],
+ )
+ with patch("django.contrib.messages.success") as mock_success:
+ self.client.force_login(self.user)
+ response = self.client.post(
+ reverse("invitedmember-delete", kwargs={"pk": invitation.pk}),
+ )
+
+ self.assertEqual(response.status_code, 302)
+
+ expected_success_message = f"You've removed {invitation.email} from the organization."
+ args, kwargs = mock_success.call_args
+ # Check if first arg is a WSGIRequest, confirms request object passed correctly
+ # WSGIRequest protocol is basically the HTTPRequest but in Django form (ie POST '/member/1/delete')
+ self.assertIsInstance(args[0], WSGIRequest)
+ # Check that the error message matches the expected error message
+ self.assertEqual(args[1], expected_success_message)
+
+ # Location is used for a 3xx HTTP status code to indicate that the URL was redirected
+ # and then confirm that we're now on Members Table page
+ self.assertEqual(response.headers["Location"], reverse("members"))
+
class TestPortfolioMemberDomainsView(TestWithUser, WebTest):
@classmethod
diff --git a/src/registrar/views/portfolio_members_json.py b/src/registrar/views/portfolio_members_json.py
index 17209f0d9..512124377 100644
--- a/src/registrar/views/portfolio_members_json.py
+++ b/src/registrar/views/portfolio_members_json.py
@@ -100,7 +100,7 @@ class PortfolioMembersJson(PortfolioMembersPermission, View):
user__permissions__domain__domain_info__portfolio=portfolio
), # only include domains in portfolio
),
- source=Value("permission", output_field=CharField()),
+ type=Value("member", output_field=CharField()),
)
.values(
"id",
@@ -112,7 +112,7 @@ class PortfolioMembersJson(PortfolioMembersPermission, View):
"additional_permissions_display",
"member_display",
"domain_info",
- "source",
+ "type",
)
)
return permissions
@@ -140,7 +140,7 @@ class PortfolioMembersJson(PortfolioMembersPermission, View):
distinct=True,
)
),
- source=Value("invitation", output_field=CharField()),
+ type=Value("invitedmember", output_field=CharField()),
).values(
"id",
"first_name",
@@ -151,7 +151,7 @@ class PortfolioMembersJson(PortfolioMembersPermission, View):
"additional_permissions_display",
"member_display",
"domain_info",
- "source",
+ "type",
)
return invitations
@@ -188,12 +188,12 @@ class PortfolioMembersJson(PortfolioMembersPermission, View):
view_only = not user.has_edit_members_portfolio_permission(portfolio) or not user_can_edit_other_users
is_admin = UserPortfolioRoleChoices.ORGANIZATION_ADMIN in (item.get("roles") or [])
- action_url = reverse("member" if item["source"] == "permission" else "invitedmember", kwargs={"pk": item["id"]})
+ action_url = reverse(item["type"], kwargs={"pk": item["id"]})
# Serialize member data
member_json = {
- "id": item.get("id", ""),
- "source": item.get("source", ""),
+ "id": item.get("id", ""), # id is id of UserPortfolioPermission or PortfolioInvitation
+ "type": item.get("type", ""), # source is member or invitedmember
"name": " ".join(filter(None, [item.get("first_name", ""), item.get("last_name", "")])),
"email": item.get("email_display", ""),
"member_display": item.get("member_display", ""),
diff --git a/src/registrar/views/portfolios.py b/src/registrar/views/portfolios.py
index 7839d209e..373d1619d 100644
--- a/src/registrar/views/portfolios.py
+++ b/src/registrar/views/portfolios.py
@@ -1,13 +1,17 @@
import logging
-from django.http import Http404
+
+from django.http import Http404, JsonResponse
from django.shortcuts import get_object_or_404, redirect, render
from django.urls import reverse
+from django.utils.safestring import mark_safe
from django.contrib import messages
+
from registrar.forms import portfolio as portfolioForms
from registrar.models import Portfolio, User
from registrar.models.portfolio_invitation import PortfolioInvitation
from registrar.models.user_portfolio_permission import UserPortfolioPermission
from registrar.models.utility.portfolio_helper import UserPortfolioPermissionChoices, UserPortfolioRoleChoices
+from registrar.views.utility.mixins import PortfolioMemberPermission
from registrar.views.utility.permission_views import (
PortfolioDomainRequestsPermissionView,
PortfolioDomainsPermissionView,
@@ -81,6 +85,58 @@ class PortfolioMemberView(PortfolioMemberPermissionView, View):
)
+class PortfolioMemberDeleteView(PortfolioMemberPermission, View):
+
+ def post(self, request, pk):
+ """
+ Find and delete the portfolio member using the provided primary key (pk).
+ Redirect to a success page after deletion (or any other appropriate page).
+ """
+ portfolio_member_permission = get_object_or_404(UserPortfolioPermission, pk=pk)
+ member = portfolio_member_permission.user
+
+ active_requests_count = member.get_active_requests_count_in_portfolio(request)
+
+ support_url = "https://get.gov/contact/"
+
+ error_message = ""
+
+ if active_requests_count > 0:
+ # If they have any in progress requests
+ error_message = mark_safe( # nosec
+ f"This member has an active domain request and can't be removed from the organization. "
+ f"Contact the .gov team to remove them."
+ )
+ elif member.is_only_admin_of_portfolio(portfolio_member_permission.portfolio):
+ # If they are the last manager of a domain
+ error_message = (
+ "There must be at least one admin in your organization. Give another member admin "
+ "permissions, make sure they log into the registrar, and then remove this member."
+ )
+
+ # From the Members Table page Else the Member Page
+ if error_message:
+ if request.headers.get("X-Requested-With") == "XMLHttpRequest":
+ return JsonResponse(
+ {"error": error_message},
+ status=400,
+ )
+ else:
+ messages.error(request, error_message)
+ return redirect(reverse("member", kwargs={"pk": pk}))
+
+ # passed all error conditions
+ portfolio_member_permission.delete()
+
+ # From the Members Table page Else the Member Page
+ success_message = f"You've removed {member.email} from the organization."
+ if request.headers.get("X-Requested-With") == "XMLHttpRequest":
+ return JsonResponse({"success": success_message}, status=200)
+ else:
+ messages.success(request, success_message)
+ return redirect(reverse("members"))
+
+
class PortfolioMemberEditView(PortfolioMemberEditPermissionView, View):
template_name = "portfolio_member_permissions.html"
@@ -177,6 +233,26 @@ class PortfolioInvitedMemberView(PortfolioMemberPermissionView, View):
)
+class PortfolioInvitedMemberDeleteView(PortfolioMemberPermission, View):
+
+ def post(self, request, pk):
+ """
+ Find and delete the portfolio invited member using the provided primary key (pk).
+ Redirect to a success page after deletion (or any other appropriate page).
+ """
+ portfolio_invitation = get_object_or_404(PortfolioInvitation, pk=pk)
+
+ portfolio_invitation.delete()
+
+ success_message = f"You've removed {portfolio_invitation.email} from the organization."
+ # From the Members Table page Else the Member Page
+ if request.headers.get("X-Requested-With") == "XMLHttpRequest":
+ return JsonResponse({"success": success_message}, status=200)
+ else:
+ messages.success(request, success_message)
+ return redirect(reverse("members"))
+
+
class PortfolioInvitedMemberEditView(PortfolioMemberEditPermissionView, View):
template_name = "portfolio_member_permissions.html"
+
.Gov domain registrants must maintain accurate contact information in the .gov registrar. Before you can manage your domain, we need you to add your contact information.
diff --git a/src/registrar/tests/test_models.py b/src/registrar/tests/test_models.py index 53206359b..0c1bdec2a 100644 --- a/src/registrar/tests/test_models.py +++ b/src/registrar/tests/test_models.py @@ -824,6 +824,92 @@ class TestUser(TestCase): cm.exception.message, "When portfolio roles or additional permissions are assigned, portfolio is required." ) + @less_console_noise_decorator + def test_get_active_requests_count_in_portfolio_returns_zero_if_no_portfolio(self): + # There is no portfolio referenced in session so should return 0 + request = self.factory.get("/") + request.session = {} + + count = self.user.get_active_requests_count_in_portfolio(request) + self.assertEqual(count, 0) + + @less_console_noise_decorator + def test_get_active_requests_count_in_portfolio_returns_count_if_portfolio(self): + request = self.factory.get("/") + request.session = {"portfolio": self.portfolio} + + # Create active requests + domain_1, _ = DraftDomain.objects.get_or_create(name="meoward1.gov") + domain_2, _ = DraftDomain.objects.get_or_create(name="meoward2.gov") + domain_3, _ = DraftDomain.objects.get_or_create(name="meoward3.gov") + domain_4, _ = DraftDomain.objects.get_or_create(name="meoward4.gov") + + # Create 3 active requests + 1 that isn't + DomainRequest.objects.create( + creator=self.user, + requested_domain=domain_1, + status=DomainRequest.DomainRequestStatus.SUBMITTED, + portfolio=self.portfolio, + ) + DomainRequest.objects.create( + creator=self.user, + requested_domain=domain_2, + status=DomainRequest.DomainRequestStatus.IN_REVIEW, + portfolio=self.portfolio, + ) + DomainRequest.objects.create( + creator=self.user, + requested_domain=domain_3, + status=DomainRequest.DomainRequestStatus.ACTION_NEEDED, + portfolio=self.portfolio, + ) + DomainRequest.objects.create( # This one should not be counted + creator=self.user, + requested_domain=domain_4, + status=DomainRequest.DomainRequestStatus.REJECTED, + portfolio=self.portfolio, + ) + + count = self.user.get_active_requests_count_in_portfolio(request) + self.assertEqual(count, 3) + + @less_console_noise_decorator + def test_is_only_admin_of_portfolio_returns_true(self): + # Create user as the only admin of the portfolio + UserPortfolioPermission.objects.create( + user=self.user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN] + ) + self.assertTrue(self.user.is_only_admin_of_portfolio(self.portfolio)) + + @less_console_noise_decorator + def test_is_only_admin_of_portfolio_returns_false_if_no_admins(self): + # No admin for the portfolio + self.assertFalse(self.user.is_only_admin_of_portfolio(self.portfolio)) + + @less_console_noise_decorator + def test_is_only_admin_of_portfolio_returns_false_if_multiple_admins(self): + # Create multiple admins for the same portfolio + UserPortfolioPermission.objects.create( + user=self.user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN] + ) + # Create another user within this test + other_user = User.objects.create(email="second_admin@igorville.gov", username="second_admin") + UserPortfolioPermission.objects.create( + user=other_user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN] + ) + self.assertFalse(self.user.is_only_admin_of_portfolio(self.portfolio)) + + @less_console_noise_decorator + def test_is_only_admin_of_portfolio_returns_false_if_user_not_admin(self): + # Create other_user for same portfolio and is given admin access + other_user = User.objects.create(email="second_admin@igorville.gov", username="second_admin") + + UserPortfolioPermission.objects.create( + user=other_user, portfolio=self.portfolio, roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN] + ) + # User doesn't have admin access so should return false + self.assertFalse(self.user.is_only_admin_of_portfolio(self.portfolio)) + class TestContact(TestCase): @less_console_noise_decorator diff --git a/src/registrar/tests/test_views_portfolio.py b/src/registrar/tests/test_views_portfolio.py index a50a78b23..b7f455936 100644 --- a/src/registrar/tests/test_views_portfolio.py +++ b/src/registrar/tests/test_views_portfolio.py @@ -2,8 +2,9 @@ from django.urls import reverse from api.tests.common import less_console_noise_decorator from registrar.config import settings from registrar.models import Portfolio, SeniorOfficial -from unittest.mock import MagicMock +from unittest.mock import MagicMock, patch from django_webtest import WebTest # type: ignore +from django.core.handlers.wsgi import WSGIRequest from registrar.models import ( DomainRequest, Domain, @@ -959,7 +960,7 @@ class TestPortfolio(WebTest): ) # Assert buttons and links within the page are correct - self.assertContains(response, "usa-button--more-actions") # test that 3 dot is present + self.assertContains(response, "wrapper-delete-action") # test that 3 dot is present self.assertContains(response, "sprite.svg#edit") # test that Edit link is present self.assertContains(response, "sprite.svg#settings") # test that Manage link is present self.assertNotContains(response, "sprite.svg#visibility") # test that View link is not present @@ -1077,9 +1078,8 @@ class TestPortfolio(WebTest): self.assertContains( response, 'This member does not manage any domains. To assign this member a domain, click "Manage"' ) - # Assert buttons and links within the page are correct - self.assertContains(response, "usa-button--more-actions") # test that 3 dot is present + self.assertContains(response, "wrapper-delete-action") # test that 3 dot is present self.assertContains(response, "sprite.svg#edit") # test that Edit link is present self.assertContains(response, "sprite.svg#settings") # test that Manage link is present self.assertNotContains(response, "sprite.svg#visibility") # test that View link is not present @@ -1392,6 +1392,510 @@ class TestPortfolio(WebTest): self.assertTrue(DomainRequest.objects.filter(pk=domain_request.pk).exists()) domain_request.delete() + @less_console_noise_decorator + @override_flag("organization_feature", active=True) + @override_flag("organization_members", active=True) + def test_members_table_contains_hidden_permissions_js_hook(self): + # In the members_table.html we use data-has-edit-permission as a boolean + # to indicate if a user has permission to edit members in the specific portfolio + + # 1. User w/ edit permission + UserPortfolioPermission.objects.get_or_create( + user=self.user, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN], + additional_permissions=[ + UserPortfolioPermissionChoices.VIEW_MEMBERS, + UserPortfolioPermissionChoices.EDIT_MEMBERS, + ], + ) + + # Create a member under same portfolio + member_email = "a_member@example.com" + member, _ = User.objects.get_or_create(username="a_member", email=member_email) + + UserPortfolioPermission.objects.get_or_create( + user=member, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], + ) + + # I log in as the User so I can see the Members Table + self.client.force_login(self.user) + + # Specifically go to the Member Table page + response = self.client.get(reverse("members")) + + self.assertContains(response, 'data-has-edit-permission="True"') + + # 2. User w/o edit permission (additional permission of EDIT_MEMBERS removed) + permission = UserPortfolioPermission.objects.get(user=self.user, portfolio=self.portfolio) + + # Remove the EDIT_MEMBERS additional permission + permission.additional_permissions = [ + perm for perm in permission.additional_permissions if perm != UserPortfolioPermissionChoices.EDIT_MEMBERS + ] + + # Save the updated permissions list + permission.save() + + # Re-fetch the page to check for updated permissions + response = self.client.get(reverse("members")) + + self.assertContains(response, 'data-has-edit-permission="False"') + + @less_console_noise_decorator + @override_flag("organization_feature", active=True) + @override_flag("organization_members", active=True) + def test_member_page_has_kebab_wrapper_for_member_if_user_has_edit_permission(self): + """Test that the kebab wrapper displays for a member with edit permissions""" + + # I'm a user + UserPortfolioPermission.objects.get_or_create( + user=self.user, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN], + additional_permissions=[ + UserPortfolioPermissionChoices.VIEW_MEMBERS, + UserPortfolioPermissionChoices.EDIT_MEMBERS, + ], + ) + + # Create a member under same portfolio + member_email = "a_member@example.com" + member, _ = User.objects.get_or_create(username="a_member", email=member_email) + + upp, _ = UserPortfolioPermission.objects.get_or_create( + user=member, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], + ) + + # I log in as the User so I can see the Manage Member page + self.client.force_login(self.user) + + # Specifically go to the Manage Member page + response = self.client.get(reverse("member", args=[upp.id]), follow=True) + + self.assertEqual(response.status_code, 200) + + # Check for email AND member type (which here is just member) + self.assertContains(response, f'data-member-name="{member_email}"') + self.assertContains(response, 'data-member-type="member"') + + @less_console_noise_decorator + @override_flag("organization_feature", active=True) + @override_flag("organization_members", active=True) + def test_member_page_has_kebab_wrapper_for_invited_member_if_user_has_edit_permission(self): + """Test that the kebab wrapper displays for an invitedmember with edit permissions""" + + # I'm a user + UserPortfolioPermission.objects.get_or_create( + user=self.user, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN], + additional_permissions=[ + UserPortfolioPermissionChoices.VIEW_MEMBERS, + UserPortfolioPermissionChoices.EDIT_MEMBERS, + ], + ) + + # Invite a member under same portfolio + invited_member_email = "invited_member@example.com" + invitation = PortfolioInvitation.objects.create( + email=invited_member_email, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], + ) + + # I log in as the User so I can see the Manage Member page + self.client.force_login(self.user) + response = self.client.get(reverse("invitedmember", args=[invitation.id]), follow=True) + + self.assertEqual(response.status_code, 200) + + # Assert the invited members email + invitedmember type + self.assertContains(response, f'data-member-name="{invited_member_email}"') + self.assertContains(response, 'data-member-type="invitedmember"') + + @less_console_noise_decorator + @override_flag("organization_feature", active=True) + @override_flag("organization_members", active=True) + def test_member_page_does_not_have_kebab_wrapper(self): + """Test that the kebab does not display.""" + + # I'm a user + UserPortfolioPermission.objects.get_or_create( + user=self.user, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN], + additional_permissions=[ + UserPortfolioPermissionChoices.VIEW_MEMBERS, + UserPortfolioPermissionChoices.EDIT_MEMBERS, + ], + ) + + # That creates a member with only view access + member_email = "member_with_view_access@example.com" + member, _ = User.objects.get_or_create(username="test_member_with_view_access", email=member_email) + + upp, _ = UserPortfolioPermission.objects.get_or_create( + user=member, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], + additional_permissions=[ + UserPortfolioPermissionChoices.VIEW_MEMBERS, + ], + ) + + # I log in as the Member with only view permissions to evaluate the pages behaviour + # when viewed by someone who doesn't have edit perms + self.client.force_login(member) + + # Go to the Manage Member page + response = self.client.get(reverse("member", args=[upp.id]), follow=True) + + self.assertEqual(response.status_code, 200) + + # Assert that the kebab edit options are unavailable + self.assertNotContains(response, 'data-member-type="member"') + self.assertNotContains(response, 'data-member-type="invitedmember"') + self.assertNotContains(response, f'data-member-name="{member_email}"') + + @less_console_noise_decorator + @override_flag("organization_feature", active=True) + @override_flag("organization_members", active=True) + def test_member_page_has_correct_form_wrapper(self): + """Test that the manage members page the right form wrapper""" + + # I'm a user + UserPortfolioPermission.objects.get_or_create( + user=self.user, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN], + additional_permissions=[ + UserPortfolioPermissionChoices.VIEW_MEMBERS, + UserPortfolioPermissionChoices.EDIT_MEMBERS, + ], + ) + + # That creates a member + member_email = "a_member@example.com" + member, _ = User.objects.get_or_create(email=member_email) + + upp, _ = UserPortfolioPermission.objects.get_or_create( + user=member, + portfolio=self.portfolio, + roles=[UserPortfolioRoleChoices.ORGANIZATION_MEMBER], + ) + + # Login as the User to see the Manage Member page + self.client.force_login(self.user) + + # Specifically go to the Manage Member page + response = self.client.get(reverse("member", args=[upp.id]), follow=True) + + # Check for a 200 response + self.assertEqual(response.status_code, 200) + + # Check for form method + that its "post" and id "member-delete-form" + self.assertContains(response, "