zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-26 04:28:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

Minor performance enhancement

Browse source
This commit is contained in:
zandercymatics 2024-01-29 15:18:22 -07:00
parent acbef25ec1
commit 11542c9ca0
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/registrar/utility/csv_export.py
View file

@ -63,7 +63,6 @@ def parse_row(columns, domain_info: DomainInformation, security_emails_dict=None
security_contacts = domain.contacts.filter(contact_type=PublicContact.ContactTypeChoices.SECURITY)
_email = security_contacts[0].email if security_contacts else None
security_email = _email if _email is not None else " "
print("in else statement....")
# These are default emails that should not be displayed in the csv report
invalid_emails = {"registrar@dotgov.gov", "dotgov@cisa.dhs.gov"}
@ -112,9 +111,9 @@ def write_body(
all_domain_infos = get_domain_infos(filter_condition, sort_fields)
# Store all security emails to avoid epp calls or excessive filters
sec_contact_ids = list(all_domain_infos.values_list("domain__security_contact_registry_id", flat=True))
sec_contact_ids = all_domain_infos.values_list("domain__security_contact_registry_id", flat=True)
security_emails_dict = {}
public_contacts = PublicContact.objects.filter(registry_id__in=sec_contact_ids)
public_contacts = PublicContact.objects.only('email', 'domain__name').select_related("domain").filter(registry_id__in=sec_contact_ids)
# Populate a dictionary of domain names and their security contacts
for contact in public_contacts: