zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-06-09 22:14:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix failing test

Browse source
This commit is contained in:
Neil Martinsen-Burrell 2023-01-09 15:05:39 -06:00
parent dc7c782050
commit 0a3c3ec9f5
No known key found for this signature in database
GPG key ID: 6A3C818CC10D0184
2 changed files with 25 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/registrar/forms/application_wizard.py
View file

@ -11,7 +11,7 @@ from registrar.models import Contact, DomainApplication, Domain
logger = logging.getLogger(__name__)
# nosec because this use of mark_safe does not introduce a cross-site scripting
# no sec because this use of mark_safe does not introduce a cross-site scripting
# vulnerability because there is no untrusted content inside. It is
# only being used to pass a specific HTML entity into a template.
REQUIRED_SUFFIX = mark_safe( # nosec
@ -145,12 +145,18 @@ class OrganizationContactForm(RegistrarForm):
federal_agency = self.cleaned_data.get("federal_agency", None)
# need the application object to know if this is federal
if self.application is None:
# hmm, no saved application object?
raise ValueError("Form has no active application object.")
# hmm, no saved application object?, default require the agency
if not federal_agency:
# no answer was selected
raise forms.ValidationError(
"Please select your federal agency.", code="required"
)
if self.application.is_federal:
if not federal_agency:
# no answer was selected
raise forms.ValidationError("Please select your federal agency.", code="required")
raise forms.ValidationError(
"Please select your federal agency.", code="required"
)
return federal_agency