mirror of
https://github.com/cisagov/manage.get.gov.git
synced 2025-08-14 13:34:10 +02:00
Fix form valid logic
This commit is contained in:
parent
2059c9fc0c
commit
09944e4ce0
1 changed files with 18 additions and 16 deletions
|
@ -1,4 +1,5 @@
|
||||||
import logging
|
import logging
|
||||||
|
import random
|
||||||
from faker import Faker
|
from faker import Faker
|
||||||
from django.db import transaction
|
from django.db import transaction
|
||||||
|
|
||||||
|
@ -51,22 +52,23 @@ class UserPortfolioPermissionFixture:
|
||||||
|
|
||||||
user_portfolio_permissions_to_create = []
|
user_portfolio_permissions_to_create = []
|
||||||
for user in users:
|
for user in users:
|
||||||
for portfolio in portfolios:
|
# Assign a random portfolio to a user
|
||||||
try:
|
portfolio = random.choice(portfolios) # nosec
|
||||||
if not UserPortfolioPermission.objects.filter(user=user, portfolio=portfolio).exists():
|
try:
|
||||||
user_portfolio_permission = UserPortfolioPermission(
|
if not UserPortfolioPermission.objects.filter(user=user, portfolio=portfolio).exists():
|
||||||
user=user,
|
user_portfolio_permission = UserPortfolioPermission(
|
||||||
portfolio=portfolio,
|
user=user,
|
||||||
roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
|
portfolio=portfolio,
|
||||||
)
|
roles=[UserPortfolioRoleChoices.ORGANIZATION_ADMIN],
|
||||||
user_portfolio_permissions_to_create.append(user_portfolio_permission)
|
)
|
||||||
else:
|
user_portfolio_permissions_to_create.append(user_portfolio_permission)
|
||||||
logger.info(
|
else:
|
||||||
f"Permission exists for user '{user.username}' "
|
logger.info(
|
||||||
f"on portfolio '{portfolio.organization_name}'."
|
f"Permission exists for user '{user.username}' "
|
||||||
)
|
f"on portfolio '{portfolio.organization_name}'."
|
||||||
except Exception as e:
|
)
|
||||||
logger.warning(e)
|
except Exception as e:
|
||||||
|
logger.warning(e)
|
||||||
|
|
||||||
# Bulk create permissions
|
# Bulk create permissions
|
||||||
cls._bulk_create_permissions(user_portfolio_permissions_to_create)
|
cls._bulk_create_permissions(user_portfolio_permissions_to_create)
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue