zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-05-20 03:19:24 +02:00
Code Issues Projects Releases Packages Wiki Activity

PR suggestions

Browse source
This commit is contained in:
zandercymatics 2024-09-11 09:25:19 -06:00
parent 4dfa2f7fe5
commit 096dce78c3
No known key found for this signature in database
GPG key ID: FF4636ABEC9682B7
2 changed files with 21 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

40
src/registrar/assets/js/get-gov.js
View file

@ -1426,9 +1426,9 @@ document.addEventListener('DOMContentLoaded', function() {
// NOTE: We may need to evolve this as we add more filters. // NOTE: We may need to evolve this as we add more filters.
document.addEventListener('focusin', function(event) { document.addEventListener('focusin', function(event) {
const accordion = document.querySelector('.usa-accordion--select'); const accordion = document.querySelector('.usa-accordion--select');
const accordionIsOpen = document.querySelector('.usa-button--filter[aria-expanded="true"]'); const accordionThatIsOpen = document.querySelector('.usa-button--filter[aria-expanded="true"]');
if (accordionIsOpen && !accordion.contains(event.target)) { if (accordionThatIsOpen && !accordion.contains(event.target)) {
closeFilters(); closeFilters();
} }
}); });
@ -1437,9 +1437,9 @@ document.addEventListener('DOMContentLoaded', function() {
// NOTE: We may need to evolve this as we add more filters. // NOTE: We may need to evolve this as we add more filters.
document.addEventListener('click', function(event) { document.addEventListener('click', function(event) {
const accordion = document.querySelector('.usa-accordion--select'); const accordion = document.querySelector('.usa-accordion--select');
const accordionIsOpen = document.querySelector('.usa-button--filter[aria-expanded="true"]'); const accordionThatIsOpen = document.querySelector('.usa-button--filter[aria-expanded="true"]');
if (accordionIsOpen && !accordion.contains(event.target)) { if (accordionThatIsOpen && !accordion.contains(event.target)) {
closeFilters(); closeFilters();
} }
}); });
@ -1607,7 +1607,7 @@ document.addEventListener('DOMContentLoaded', function() {
const actionLabel = request.action_label; const actionLabel = request.action_label;
const submissionDate = request.last_submitted_date ? new Date(request.last_submitted_date).toLocaleDateString('en-US', options) : `<span class="text-base">Not submitted</span>`; const submissionDate = request.last_submitted_date ? new Date(request.last_submitted_date).toLocaleDateString('en-US', options) : `<span class="text-base">Not submitted</span>`;
// Delete markup will either be a simple trigger or a 3 dots menu with a hidden trigger (in the case of portfolio requests page) // The markup for the delete function either be a simple trigger or a 3 dots menu with a hidden trigger (in the case of portfolio requests page)
// Even if the request is not deletable, we may need these empty strings for the td if the deletable column is displayed // Even if the request is not deletable, we may need these empty strings for the td if the deletable column is displayed
let modalTrigger = ''; let modalTrigger = '';
@ -1884,35 +1884,31 @@ document.addEventListener('DOMContentLoaded', function() {
}); });
} }
function closeMoreActionMenu(accordionIsOpen) { function closeMoreActionMenu(accordionThatIsOpen) {
if (accordionIsOpen.getAttribute("aria-expanded") === "true") { if (accordionThatIsOpen.getAttribute("aria-expanded") === "true") {
accordionIsOpen.click(); accordionThatIsOpen.click();
} }
} }
document.addEventListener('focusin', function(event) { document.addEventListener('focusin', function(event) {
const accordions = document.querySelectorAll('.usa-accordion--more-actions'); closeOpenAccordions(event);
const openAccordions = document.querySelectorAll('.usa-button--more-actions[aria-expanded="true"]');
openAccordions.forEach((openAccordionButton) => {
const accordion = openAccordionButton.closest('.usa-accordion--more-actions'); // Find the corresponding accordion
if (accordion && !accordion.contains(event.target)) {
closeMoreActionMenu(openAccordionButton); // Close the accordion if the focus is outside
}
});
}); });
document.addEventListener('click', function(event) { document.addEventListener('click', function(event) {
const accordions = document.querySelectorAll('.usa-accordion--more-actions'); closeOpenAccordions(event);
});
function closeOpenAccordions(event) {
const openAccordions = document.querySelectorAll('.usa-button--more-actions[aria-expanded="true"]'); const openAccordions = document.querySelectorAll('.usa-button--more-actions[aria-expanded="true"]');
openAccordions.forEach((openAccordionButton) => { openAccordions.forEach((openAccordionButton) => {
const accordion = openAccordionButton.closest('.usa-accordion--more-actions'); // Find the corresponding accordion // Find the corresponding accordion
const accordion = openAccordionButton.closest('.usa-accordion--more-actions');
if (accordion && !accordion.contains(event.target)) { if (accordion && !accordion.contains(event.target)) {
closeMoreActionMenu(openAccordionButton); // Close the accordion if the click is outside // Close the accordion if the click is outside
closeMoreActionMenu(openAccordionButton);
} }
}); });
}); }
// Initial load // Initial load
loadDomainRequests(1); loadDomainRequests(1);

6
src/registrar/context_processors.py
View file

@ -60,7 +60,7 @@ def add_has_profile_feature_flag_to_context(request):
def portfolio_permissions(request): def portfolio_permissions(request):
"""Make portfolio permissions for the request user available in global context""" """Make portfolio permissions for the request user available in global context"""
default_context = { portfolio_context = {
"has_base_portfolio_permission": False, "has_base_portfolio_permission": False,
"has_any_domains_portfolio_permission": False, "has_any_domains_portfolio_permission": False,
"has_any_requests_portfolio_permission": False, "has_any_requests_portfolio_permission": False,
@ -94,8 +94,8 @@ def portfolio_permissions(request):
"has_organization_requests_flag": request.user.has_organization_requests_flag(), "has_organization_requests_flag": request.user.has_organization_requests_flag(),
"has_organization_members_flag": request.user.has_organization_members_flag(), "has_organization_members_flag": request.user.has_organization_members_flag(),
} }
return default_context return portfolio_context
except AttributeError: except AttributeError:
# Handles cases where request.user might not exist # Handles cases where request.user might not exist
return default_context return portfolio_context