remove old code

src/registrar/models/domain.py

@@ -245,7 +245,6 @@ class Domain(TimeStampedModel, DomainHelper):
         is called in the validate function on the request/domain page
 
         throws- RegistryError or InvalidDomainError"""
-        return True
         if not cls.string_could_be_domain(domain):
             logger.warning("Not a valid domain: %s" % str(domain))
             # throw invalid domain error so that it can be caught in

src/registrar/templates/domain_request_dotgov_domain.html

@@ -61,7 +61,7 @@
 
   <fieldset class="usa-fieldset margin-top-1 dotgov-domain-form" id="form-container">
     <legend>
-      <h2 id="alternative-domains">Alternative domains (optional)</h2>
+      <h2 id="alternative-domains-title">Alternative domains (optional)</h2>
     </legend>
 
     <p id="alt_domain_instructions" class="margin-top-05">Are there other domains you’d like if we can’t give
@@ -81,7 +81,7 @@
     {% endwith %}
     
     <div class="usa-sr-only" id="alternative-domains__add-another-alternative">Add another alternative domain</div> 
-    <button aria-labelledby="alternative-domains" aria-describedby="alternative-domains__add-another-alternative" type="button" value="save" class="usa-button usa-button--unstyled usa-button--with-icon" id="add-form">
+    <button aria-labelledby="alternative-domains-title" aria-describedby="alternative-domains__add-another-alternative" type="button" value="save" class="usa-button usa-button--unstyled usa-button--with-icon" id="add-form">
       <svg class="usa-icon" aria-hidden="true" focusable="false" role="img" width="24" height="24">
         <use xlink:href="{%static 'img/sprite.svg'%}#add_circle"></use>
       </svg><span class="margin-left-05">Add another alternative</span>
@@ -94,7 +94,7 @@
       type="button"
       class="usa-button usa-button--outline"
       validate-for="{{ forms.1.requested_domain.auto_id }}"
-      aria-labelledby="alternative-domains"
+      aria-labelledby="alternative-domains-title"
       aria-describedby="alternative-domains__check-availability"
       >Check availability</button>
     </div>

src/registrar/templates/home.html

@@ -18,9 +18,10 @@
     <h1>Manage your domains</h1>
 
     <p class="margin-top-4">
-      <button data-href="{% url 'domain-request:start' %}" class="usa-button use-button-as-link">
+      <a href="{% url 'domain-request:start' %}" class="usa-button"
+      >
         Start a new domain request
-      </button>
+      </a>
     </p>
 
     {% include "includes/domains_table.html" with user_domain_count=user_domain_count %}

src/registrar/templates/portfolio_requests.html

@@ -26,9 +26,10 @@
             <div class="mobile:grid-col-12 tablet:grid-col-6">
  
                 <p class="float-right-tablet tablet:margin-y-0">
-                    <button data-href="{% url 'domain-request:start' %}" class="usa-button use-button-as-link">
+                    <a href="{% url 'domain-request:start' %}" class="usa-button"
+                    >
                         Start a new domain request
-                    </button>
+                    </a>
                 </p>
             </div>
         {% else %}