zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-04 18:23:29 +02:00
Code Issues Projects Releases Packages Wiki Activity

updated clean in form

Browse source
This commit is contained in:
David Kennedy 2023-12-29 15:37:31 -05:00
parent ea043bf504
commit 06a2e39c12
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 6 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/registrar/forms/application_wizard.py
View file

@ -587,19 +587,12 @@ class OtherContactsForm(RegistrarForm):
# Override clean in order to correct validation logic
def clean(self):
# NOTE: using self.cleaned_data directly apparently causes a CORS error
cleaned = super().clean()
form_is_empty = all(v is None or v == "" for v in cleaned.values())
# NOTE: Phone number and email do NOT show up in cleaned values.
# I have spent hours tyring to figure out why, but have no idea...
# so for now we will grab their values from the raw data...
for i in self.data:
if "phone" in i or "email" in i:
# check if it has data
field_value = self.data.get(i)
# update the bool on whether the form is actually empty
form_is_empty = field_value == "" or field_value is None
form_is_empty = True
for name, field in self.fields.items():
value = field.widget.value_from_datadict(self.data, self.files, self.add_prefix(name))
if value is not None and value != "":
form_is_empty = False
if form_is_empty:
# clear any errors raised by the form fields
@ -613,7 +606,7 @@ class OtherContactsForm(RegistrarForm):
if field in self.errors:
del self.errors[field]
return cleaned
return self.cleaned_data
class BaseOtherContactsFormSet(RegistrarFormSet):