zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-25 03:58:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch 'main' into XX/documentation-for-cloning-workflow

Browse source
This commit is contained in:
Matt-Spence 2025-01-06 10:44:57 -05:00 • committed by GitHub
commit 04e73ce42b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
141 changed files with 5837 additions and 2551 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/dev-practices/code_review.md
View file

@ -4,7 +4,6 @@ Pull requests should be titled in the format of `#issue_number: Descriptive name
Pull requests including a migration should be suffixed with ` - MIGRATION`
After creating a pull request, pull request submitters should:
- Add at least 2 developers as PR reviewers (only 1 will need to approve).
- Message on Slack or in standup to notify the team that a PR is ready for review.
- If any model was updated to modify/add/delete columns, run makemigrations and commit the associated migrations file.