Add more copy changes

This commit is contained in:
Erin Song 2024-10-04 10:17:39 -07:00
parent c553ebb773
commit 0283902615
No known key found for this signature in database
2 changed files with 4 additions and 3 deletions

View file

@ -65,14 +65,14 @@ Resolves #001
#### Validated user-facing changes as a developer
**Note:** Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
- [ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
- [ ] Checked keyboard navigability
- [ ] Meets all designs and user flows provided by design/product
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
- [ ] (Rarely needed) Tested as both an analyst and applicant user
**Note:** Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
### As a designer reviewer, I have
#### Verified that the changes match the design intention

View file

@ -6,9 +6,10 @@ After creating a pull request, pull request submitters should:
- If any model was updated to modify/add/delete columns, run makemigrations and commit the associated migrations file.
- If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
## Pull Requests for User-facing changes
Code changes on user-facing features (excluding content updates) require approval from at least one developer and one designer.
All other changes require just a single approving review.
## Pull Requests for User-facing changes
When making user-facing changes, test that your changes work on multiple browsers including Chrome, Microsoft Edge, Firefox, and Safari.
## Coding standards