zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-20 09:46:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add more copy changes

Browse source
This commit is contained in:
Erin Song 2024-10-04 10:17:39 -07:00
parent c553ebb773
commit 0283902615
No known key found for this signature in database
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
docs/dev-practices/code_review.md
View file

@ -6,9 +6,10 @@ After creating a pull request, pull request submitters should:
- If any model was updated to modify/add/delete columns, run makemigrations and commit the associated migrations file.
- If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
## Pull Requests for User-facing changes
Code changes on user-facing features (excluding content updates) require approval from at least one developer and one designer.
All other changes require just a single approving review.
## Pull Requests for User-facing changes
When making user-facing changes, test that your changes work on multiple browsers including Chrome, Microsoft Edge, Firefox, and Safari.
## Coding standards