diff --git a/src/registrar/forms/portfolio.py b/src/registrar/forms/portfolio.py index d807b4184..92b68c86a 100644 --- a/src/registrar/forms/portfolio.py +++ b/src/registrar/forms/portfolio.py @@ -98,14 +98,8 @@ class PortfolioSeniorOfficialForm(forms.ModelForm): "full_name": forms.TextInput(attrs={"readonly": "readonly"}) } - # the database fields have blank=True so ModelForm doesn't create - # required fields by default. Use this list in __init__ to mark each - # of these fields as required - required = ["first_name", "last_name", "title", "email"] def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs) - for field_name in self.required: - self.fields[field_name].required = True if self.instance: self.fields["full_name"].initial = self.instance.get_formatted_name() diff --git a/src/registrar/templates/portfolio_senior_official.html b/src/registrar/templates/portfolio_senior_official.html index 9566736a0..12ddab908 100644 --- a/src/registrar/templates/portfolio_senior_official.html +++ b/src/registrar/templates/portfolio_senior_official.html @@ -23,34 +23,19 @@

Your senior official is a person within your organization who can authorize domain requests.

- {% if santa_exists %} - {% include "includes/form_errors.html" with form=form %} - {% include "includes/required_fields.html" %} -
- {% csrf_token %} - {% input_with_errors form.first_name %} - {% input_with_errors form.last_name %} - {% input_with_errors form.title %} - {% input_with_errors form.email %} - -
+

The senior official for your organization can’t be updated here. To suggest an update, email help@get.gov

+ + {% if not senior_official %} +

No senior official was found for this portfolio.

{% else %} -

The senior official for your organization can’t be updated here. To suggest an update, email help@get.gov

- - {% if not senior_official %} -

No senior official was found for this portfolio.

- {% else %} - {% if form.full_name.value is not None %} - {% include "includes/input_read_only.html" with field=form.full_name %} - {% endif %} - {% if form.title.value is not None %} - {% include "includes/input_read_only.html" with field=form.title %} - {% endif %} - {% if form.email.value is not None %} - {% include "includes/input_read_only.html" with field=form.email %} - {% endif %} + {% if form.full_name.value is not None %} + {% include "includes/input_read_only.html" with field=form.full_name %} + {% endif %} + {% if form.title.value is not None %} + {% include "includes/input_read_only.html" with field=form.title %} + {% endif %} + {% if form.email.value is not None %} + {% include "includes/input_read_only.html" with field=form.email %} {% endif %} {% endif %} diff --git a/src/registrar/views/portfolios.py b/src/registrar/views/portfolios.py index 3c851841a..8879f020c 100644 --- a/src/registrar/views/portfolios.py +++ b/src/registrar/views/portfolios.py @@ -99,6 +99,7 @@ class PortfolioOrganizationView(PortfolioBasePermissionView, FormMixin): class PortfolioSeniorOfficialView(PortfolioBasePermissionView, FormMixin): """ View to handle displaying and updating the portfolio's senior official details. + For now, this view is readonly. """ model = Portfolio @@ -130,31 +131,3 @@ class PortfolioSeniorOfficialView(PortfolioBasePermissionView, FormMixin): self.object = self.get_object() form = self.get_form() return self.render_to_response(self.get_context_data(form=form)) - - # These functions are included for future compatibility, but for now - # we do not offer an edit mode for senior officials. - def post(self, request, *args, **kwargs): - """Handle POST requests to process form submission.""" - self.object = self.get_object() - form = self.get_form() - if form.is_valid(): - return self.form_valid(form) - else: - return self.form_invalid(form) - - def form_valid(self, form): - """Handle the case when the form is valid.""" - senior_official = form.save() - portfolio = self.get_object() - portfolio.senior_official = senior_official - portfolio.save() - messages.success(self.request, "The Senior Official for this portfolio has been updated.") - return super().form_valid(form) - - def form_invalid(self, form): - """Handle the case when the form is invalid.""" - return self.render_to_response(self.get_context_data(form=form)) - - def get_success_url(self): - """Redirect to the overview page for the portfolio.""" - return reverse("senior-official")