Commit graph

6 commits

Author SHA1 Message Date
Artur Beljajev
fa52001be6 Upgrade to Rails 5.0
Closes #377
2019-11-15 15:26:33 +02:00
Artur Beljajev
42c574746c Simplify Puma config 2019-10-16 12:54:59 +03:00
Artur Beljajev
d8acd99879 Use block variable 2019-10-16 12:47:50 +03:00
Artur Beljajev
ba5a7b1745 Require application_system_test_case explicitly 2019-09-03 18:40:52 +03:00
Maciej Szlosarczyk
526a9ccd58
Change test structure to follow closer newer Rails 5 rules
* Create new class called ApplicationIntegrationTest, so we don't have
  to override ActionDispatch::IntegrationTest
* Move UI tests to inherit from ApplicationSystemTestCase
* Existing REST API or EPP tests inherit from
  ApplicationIntegrationTest.
* Move `require 'application_system_test_case'` at the end of
  `test_helper`

I don't particularly agree with the Rails' convention of treating UI
tests as system tests and API tests as integration tests, but I see no
benefit in actively fighting against it.
2018-07-27 09:36:27 +03:00
Maciej Szlosarczyk
3acd605b90
Change inheritance structure to match the one from Rails 5 more
In the future, ApplicationSystemTestCase should inherit from
ActionDispatch::SystemTestCase and JavaScriptApplicationSystemTestCase
could possibly be removed if the `driven_by` method works as it is
promised in Rails documentation:

http://api.rubyonrails.org/v5.2/classes/ActionDispatch/SystemTestCase.html

Consider introducing another class between
ActionDispatch::IntegrationTest and other items inheriting from it, as
the general Rails practice seems to have `ApplicationIntegrationTest`,
as we do have `ApplicationRecord` and `ApplicationController`.
2018-07-10 17:10:26 +03:00