Commit graph

9 commits

Author SHA1 Message Date
Maciej Szlosarczyk
07072ec6cb
Merge branch 'master' into registry-927 2018-08-17 11:28:41 +03:00
Maciej Szlosarczyk
c028c0e477
Add more tests to deposit handling 2018-08-15 20:18:07 +03:00
Maciej Szlosarczyk
b4b404888b
Disallow deposits that are lower than 0.01 EUR 2018-08-15 12:25:19 +03:00
Maciej Szlosarczyk
0a0962e007
Write tests around API for domain lock 2018-08-10 14:18:24 +03:00
Maciej Szlosarczyk
faeeb55bc7
Add badges to locked domains 2018-08-09 13:57:31 +03:00
Maciej Szlosarczyk
7ce092dff2
Add final assertion
To make sure that the domain is in the right state after out-of-order
execution of the lock removal
2018-08-08 15:49:37 +03:00
Maciej Szlosarczyk
dffe865d89
Add ability for admin to remove registry lock 2018-08-08 15:43:29 +03:00
Maciej Szlosarczyk
526a9ccd58
Change test structure to follow closer newer Rails 5 rules
* Create new class called ApplicationIntegrationTest, so we don't have
  to override ActionDispatch::IntegrationTest
* Move UI tests to inherit from ApplicationSystemTestCase
* Existing REST API or EPP tests inherit from
  ApplicationIntegrationTest.
* Move `require 'application_system_test_case'` at the end of
  `test_helper`

I don't particularly agree with the Rails' convention of treating UI
tests as system tests and API tests as integration tests, but I see no
benefit in actively fighting against it.
2018-07-27 09:36:27 +03:00
Maciej Szlosarczyk
3acd605b90
Change inheritance structure to match the one from Rails 5 more
In the future, ApplicationSystemTestCase should inherit from
ActionDispatch::SystemTestCase and JavaScriptApplicationSystemTestCase
could possibly be removed if the `driven_by` method works as it is
promised in Rails documentation:

http://api.rubyonrails.org/v5.2/classes/ActionDispatch/SystemTestCase.html

Consider introducing another class between
ActionDispatch::IntegrationTest and other items inheriting from it, as
the general Rails practice seems to have `ApplicationIntegrationTest`,
as we do have `ApplicationRecord` and `ApplicationController`.
2018-07-10 17:10:26 +03:00