Improve Ident validation, extract Ident from Contact

#569

spec/requests/epp/contact/create/ident_spec.rb

@@ -0,0 +1,237 @@
+require 'rails_helper'
+
+RSpec.describe 'EPP contact:create' do
+  let(:request) { post '/epp/command/create', frame: request_xml }
+
+  before do
+    Setting.address_processing = false
+    sign_in_to_epp_area
+  end
+
+  context 'when all ident params are valid' do
+    let(:ident) { Contact.first.identifier }
+    let(:request_xml) { <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <contact:create xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+              <contact:postalInfo>
+                <contact:name>test</contact:name>
+              </contact:postalInfo>
+              <contact:voice>+1.2</contact:voice>
+              <contact:email>test@test.com</contact:email>
+            </contact:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:ident type="priv" cc="US">test</eis:ident>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+    }
+
+    it 'creates a contact' do
+      expect { request }.to change { Contact.count }.from(0).to(1)
+    end
+
+    it 'saves ident type' do
+      request
+      expect(ident.type).to eq('priv')
+    end
+
+    it 'saves ident country code' do
+      request
+      expect(ident.country_code).to eq('US')
+    end
+
+    specify do
+      request
+      expect(epp_response).to have_result(:success)
+    end
+  end
+
+  context 'when code is blank' do
+    let(:request_xml) { <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <contact:create xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+              <contact:postalInfo>
+                <contact:name>test</contact:name>
+              </contact:postalInfo>
+              <contact:voice>+1.2</contact:voice>
+              <contact:email>test@test.com</contact:email>
+            </contact:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:ident type="priv" cc="US"></eis:ident>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+    }
+
+    it 'does not create a contact' do
+      expect { request }.to_not change { Contact.count }
+    end
+
+    specify do
+      request
+      expect(epp_response).to have_result(:required_param_missing,
+                                          'Required parameter missing: extension > extdata > ident [ident]')
+    end
+  end
+
+  context 'when code is invalid' do
+    let(:request_xml) { <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <contact:create xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+              <contact:postalInfo>
+                <contact:name>test</contact:name>
+              </contact:postalInfo>
+              <contact:voice>+1.2</contact:voice>
+              <contact:email>test@test.com</contact:email>
+            </contact:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:ident type="priv" cc="EE">invalid</eis:ident>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+    }
+
+    it 'does not create a contact' do
+      expect { request }.to_not change { Contact.count }
+    end
+
+    specify do
+      request
+
+      message = 'Ident code does not conform to national identification number format of Estonia'
+      expect(epp_response).to have_result(:param_syntax_error, message)
+    end
+  end
+
+  context 'when country code is absent' do
+    let(:request_xml) { <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <contact:create xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+              <contact:postalInfo>
+                <contact:name>test</contact:name>
+              </contact:postalInfo>
+              <contact:voice>+1.2</contact:voice>
+              <contact:email>test@test.com</contact:email>
+            </contact:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:ident type="priv">test</eis:ident>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+    }
+
+    it 'does not create a contact' do
+      expect { request }.to_not change { Contact.count }
+    end
+
+    specify do
+      request
+      expect(epp_response).to have_result(:required_param_missing,
+                                          'Required ident attribute missing: cc')
+    end
+  end
+
+  context 'when country code is blank' do
+    let(:request_xml) { <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <contact:create xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+              <contact:postalInfo>
+                <contact:name>test</contact:name>
+              </contact:postalInfo>
+              <contact:voice>+1.2</contact:voice>
+              <contact:email>test@test.com</contact:email>
+            </contact:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:ident type="priv" cc="">test</eis:ident>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+    }
+
+    it 'does not create a contact' do
+      expect { request }.to_not change { Contact.count }
+    end
+
+    specify do
+      request
+      expect(epp_response).to have_result(:syntax_error)
+    end
+  end
+
+  context 'when mismatches' do
+    let(:request_xml) { <<-XML
+      <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+      <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+        <command>
+          <create>
+            <contact:create xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+              <contact:postalInfo>
+                <contact:name>test</contact:name>
+              </contact:postalInfo>
+              <contact:voice>+1.2</contact:voice>
+              <contact:email>test@test.com</contact:email>
+            </contact:create>
+          </create>
+          <extension>
+            <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+              <eis:ident type="priv" cc="DE">test</eis:ident>
+            </eis:extdata>
+          </extension>
+        </command>
+      </epp>
+    XML
+    }
+
+    before do
+      mismatches = [
+        Contact::Ident::Mismatch.new('priv', Country.new('DE')),
+      ]
+      allow(Contact::Ident).to receive(:mismatches).and_return(mismatches)
+    end
+
+    it 'does not create a contact' do
+      expect { request }.to_not change { Contact.count }
+    end
+
+    specify do
+      request
+      expect(epp_response).to have_result(:param_syntax_error,
+                                          'Ident type "priv" is invalid for Germany')
+    end
+  end
+end

spec/requests/epp/contact/update/ident_spec.rb

@@ -1,6 +1,9 @@
 require 'rails_helper'
 
+# https://github.com/internetee/registry/issues/576
+
 RSpec.describe 'EPP contact:update' do
+  let(:ident) { contact.identifier }
   let(:request) { post '/epp/command/update', frame: request_xml }
   let(:request_xml) { <<-XML
     <?xml version="1.0" encoding="UTF-8" standalone="no"?>
@@ -18,7 +21,7 @@ RSpec.describe 'EPP contact:update' do
         </update>
         <extension>
           <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
-            <eis:ident cc="GB" type="priv">test</eis:ident>
+            <eis:ident cc="US" type="priv">test</eis:ident>
           </eis:extdata>
         </extension>
       </command>
@@ -30,45 +33,128 @@ RSpec.describe 'EPP contact:update' do
     sign_in_to_epp_area
   end
 
-  context 'when submitted ident matches current one' do
-    let!(:contact) { create(:contact, code: 'TEST', ident: 'test', ident_type: 'org', ident_country_code: 'US') }
+  context 'when contact ident is valid' do
+    let!(:contact) { create(:contact, code: 'TEST', ident: 'test', ident_type: 'priv', ident_country_code: 'US') }
 
-    it 'updates :ident_type' do
-      request
-      contact.reload
-      expect(contact.ident_type).to eq('priv')
+    it 'does not update code' do
+      expect { request; contact.reload }.to_not change { ident.code }
     end
 
-    it 'updates :ident_country_code' do
-      request
-      contact.reload
-      expect(contact.ident_country_code).to eq('GB')
+    it 'does not update type' do
+      expect { request; contact.reload }.to_not change { ident.type }
+    end
+
+    it 'does not update country code' do
+      expect { request; contact.reload }.to_not change { ident.country_code }
     end
 
     specify do
       request
-      expect(response).to have_code_of(1000)
+
+      message = 'Data management policy violation:' \
+                ' update of ident not allowed, please consider creating new contact object'
+      expect(epp_response).to have_result(:data_management_policy_violation, message)
     end
   end
 
-  context 'when submitted ident does not match current one' do
-    let!(:contact) { create(:contact, code: 'TEST', ident: 'some-ident', ident_type: 'org', ident_country_code: 'US') }
+  context 'when contact ident is invalid' do
+    let(:contact) { build(:contact, code: 'TEST', ident: 'test', ident_type: nil, ident_country_code: nil) }
 
-    it 'does not update :ident_type' do
-      request
-      contact.reload
-      expect(contact.ident_type).to eq('org')
+    before do
+      contact.save(validate: false)
     end
 
-    it 'does not update :ident_country_code' do
-      request
-      contact.reload
-      expect(contact.ident_country_code).to eq('US')
+    context 'when submitted ident is the same as current one' do
+      let(:request_xml) { <<-XML
+        <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+        <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+          <command>
+            <update>
+              <contact:update xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+                <contact:id>TEST</contact:id>
+                <contact:chg>
+                  <contact:postalInfo>
+                    <contact:name>test</contact:name>
+                  </contact:postalInfo>
+                </contact:chg>
+              </contact:update>
+            </update>
+            <extension>
+              <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+                <eis:ident cc="US" type="priv">test</eis:ident>
+              </eis:extdata>
+            </extension>
+          </command>
+        </epp>
+      XML
+      }
+
+      it 'does not update code' do
+        expect { request; contact.reload }.to_not change { ident.code }
+      end
+
+      it 'updates type' do
+        request
+        contact.reload
+        expect(ident.type).to eq('priv')
+      end
+
+      it 'updates country code' do
+        request
+        contact.reload
+        expect(ident.country_code).to eq('US')
+      end
+
+      specify do
+        request
+        expect(epp_response).to have_result(:success)
+      end
     end
 
-    specify do
-      request
-      expect(response).to have_code_of(2308)
+    context 'when submitted ident is different from current one' do
+      let(:request_xml) { <<-XML
+        <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+        <epp xmlns="https://epp.tld.ee/schema/epp-ee-1.0.xsd">
+          <command>
+            <update>
+              <contact:update xmlns:contact="https://epp.tld.ee/schema/contact-ee-1.1.xsd">
+                <contact:id>TEST</contact:id>
+                <contact:chg>
+                  <contact:postalInfo>
+                    <contact:name>test</contact:name>
+                  </contact:postalInfo>
+                </contact:chg>
+              </contact:update>
+            </update>
+            <extension>
+              <eis:extdata xmlns:eis="https://epp.tld.ee/schema/eis-1.0.xsd">
+                <eis:ident cc="US" type="priv">another-test</eis:ident>
+              </eis:extdata>
+            </extension>
+          </command>
+        </epp>
+      XML
+      }
+
+      it 'does not update code' do
+        expect { request; contact.reload }.to_not change { ident.code }
+      end
+
+      it 'does not update type' do
+        expect { request; contact.reload }.to_not change { ident.type }
+      end
+
+      it 'does not update country code' do
+        expect { request; contact.reload }.to_not change { ident.country_code }
+      end
+
+      specify do
+        request
+
+        message = 'Data management policy violation:' \
+                ' update of ident not allowed, please consider creating new contact object'
+        expect(epp_response).to have_result(:data_management_policy_violation, message)
+      end
     end
   end
 end