Merge pull request #1914 from internetee/1837-invalidate-emails-with-bounces

Add check for bounce presence in #failed? method of verification

app/models/email_address_verification.rb

@@ -34,13 +34,17 @@ class EmailAddressVerification < ApplicationRecord
   end
 
   def failed?
-    verified_at.present? && !success
+    bounce_present? || (verified_at.present? && !success)
   end
 
   def verified?
     success
   end
 
+  def bounce_present?
+    BouncedMailAddress.find_by(email: email).present?
+  end
+
   def check_force_delete
     return unless failed?
 

test/models/bounced_mail_address_test.rb

@@ -117,6 +117,15 @@ class BouncedMailAddressTest < ActiveSupport::TestCase
     assert_equal 'smtp; 550 5.1.1 user unknown', bounced_mail.diagnostic
   end
 
+  def test_email_with_bounce_considered_nonverified
+    BouncedMailAddress.record(sns_bounce_payload)
+    bounced_mail = BouncedMailAddress.last
+    registrant = domains(:shop).registrant
+
+    assert_equal registrant.email, bounced_mail.email
+    assert registrant.email_verification.failed?
+  end
+
   def sns_bounce_payload
     {
       "notificationType": "Bounce",