Merge branch 'registry-693' into registry-694

app/api/repp/domain_transfers_v1.rb

@@ -15,6 +15,7 @@ module Repp
 
         new_registrar = current_user.registrar
         domain_transfers = params['data']['domainTransfers']
+        successful_domain_transfers = []
         errors = []
 
         domain_transfers.each do |domain_transfer|
@@ -25,6 +26,7 @@ module Repp
           if domain
             if domain.transfer_code == transfer_code
               domain.transfer(new_registrar)
+              successful_domain_transfers << { type: 'domain_transfer' }
             else
               errors << { title: "#{domain_name} transfer code is wrong" }
             end
@@ -34,9 +36,8 @@ module Repp
         end
 
         if errors.none?
-          status 204
-          body false
-          @response = {}
+          status 200
+          @response = { data: successful_domain_transfers }
         else
           status 400
           @response = { errors: errors }

doc/repp/v1/domain_transfers.md

@@ -28,9 +28,21 @@ Authorization: Basic dGVzdDp0ZXN0dGVzdA==
 
 #### Response on success
 ```
-HTTP/1.1 204
+HTTP/1.1 200
+Content-Type: application/json
+{
+   "data":[
+      {
+         "type":"domain_transfer"
+      },
+      {
+         "type":"domain_transfer"
+      }
+   ]
+}
 ```
 
+
 #### Response on failure
 ```
 HTTP/1.1 400

test/integration/api/domain_transfers_test.rb

@@ -5,9 +5,12 @@ class APIDomainTransfersTest < ActionDispatch::IntegrationTest
     request_params = { format: :json,
                        data: { domainTransfers: [{ domainName: 'shop.test', transferCode: '65078d5' }] } }
     post '/repp/v1/domain_transfers', request_params, { 'HTTP_AUTHORIZATION' => http_auth_key }
-    assert_response 204
     assert_equal registrars(:goodnames), domains(:shop).registrar
-    assert_empty response.body
+    assert_response 200
+    assert_equal ({ data: [{
+                             type: 'domain_transfer'
+                           }] }),
+                 JSON.parse(response.body, symbolize_names: true)
   end
 
   def test_fails_if_domain_does_not_exist