Merge pull request #2433 from internetee/remove-feature-toggle

remove eis-billing feature toggle

app/models/billing/reference_no.rb

@@ -4,13 +4,8 @@ module Billing
     MULTI_REGEXP = /(\d{2,20})/
 
     def self.generate
-      if Feature.billing_system_integrated?
-        result = EisBilling::GetReferenceNumber.send_request
-        JSON.parse(result.body)['reference_number']
-      else
-        base = Base.generate
-        "#{base}#{base.check_digit}"
-      end
+      result = EisBilling::GetReferenceNumber.send_request
+      JSON.parse(result.body)['reference_number']
     end
 
     def self.valid?(ref)

app/models/invoice.rb

@@ -62,39 +62,13 @@ class Invoice < ApplicationRecord
     throw(:abort)
   end
 
-  def invoice_number_from_billing
+  def set_invoice_number
     result = EisBilling::GetInvoiceNumber.send_invoice
     validate_invoice_number(result)
 
     self.number = JSON.parse(result.body)['invoice_number'].to_i
   end
 
-  def generate_invoice_number_legacy
-    last_no = Invoice.all
-                     .where(number: Setting.invoice_number_min.to_i...Setting.invoice_number_max.to_i)
-                     .order(number: :desc)
-                     .limit(1)
-                     .pick(:number)
-
-    if last_no && last_no >= Setting.invoice_number_min.to_i
-      self.number = last_no + 1
-    else
-      self.number = Setting.invoice_number_min.to_i
-    end
-
-    return if number <= Setting.invoice_number_max.to_i
-
-    billing_out_of_range_issue
-  end
-
-  def set_invoice_number
-    if Feature.billing_system_integrated?
-      invoice_number_from_billing
-    else
-      generate_invoice_number_legacy
-    end
-  end
-
   def to_s
     I18n.t('invoice_no', no: number)
   end

app/models/registrar.rb

@@ -146,20 +146,13 @@ class Registrar < ApplicationRecord # rubocop:disable Metrics/ClassLength
                    .deliver_later(wait: 1.minute)
     end
 
-    if Feature.billing_system_integrated?
-      add_invoice_instance = EisBilling::AddDeposits.new(invoice)
-      result = add_invoice_instance.send_invoice
+    add_invoice_instance = EisBilling::AddDeposits.new(invoice)
+    result = add_invoice_instance.send_invoice
 
-      link = JSON.parse(result.body)['everypay_link']
+    link = JSON.parse(result.body)['everypay_link']
 
-      invoice.update(payment_link: link)
-    end
-
-    if Feature.billing_system_integrated?
-      SendEInvoiceTwoJob.set(wait: 1.minute).perform_now(invoice.id, payable: payable)
-    else
-      SendEInvoiceJob.set(wait: 1.minute).perform_now(invoice.id, payable: payable)
-    end
+    invoice.update(payment_link: link)
+    SendEInvoiceJob.set(wait: 1.minute).perform_now(invoice.id, payable: payable)
 
     invoice
   end