zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-07 21:25:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

REPP: custom success response handler

Browse source
This commit is contained in:
Karl Erik Õunapuu 2020-10-09 13:10:28 +03:00
parent 2e8ce7dbc4
commit f6580bd79a
No known key found for this signature in database
GPG key ID: C9DD647298A34764
2 changed files with 38 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/controllers/repp/v1/base_controller.rb
View file

@ -13,6 +13,13 @@ module Repp
private private
def render_success(code: nil, message: nil, data: nil)
resp = { code: code || 1000, message: message || 'Command completed successfully',
data: data || {} }
render(json: resp, status: :ok)
end
def epp_errors def epp_errors
@errors ||= [] @errors ||= []
end end

85
app/controllers/repp/v1/contacts_controller.rb
View file

@ -22,76 +22,49 @@ module Repp
## GET /repp/v1/contacts/1 ## GET /repp/v1/contacts/1
def show def show
render(json: @contact.as_json, status: :ok) render_success(data: @contact.as_json)
end end
## GET /repp/v1/contacts/check/1 ## GET /repp/v1/contacts/check/1
def check def check
contact = Epp::Contact.find_by(code: params[:id]) contact = Epp::Contact.find_by(code: params[:id])
data = { contact: { id: params[:id], available: contact.nil? } }
render json: { render_success(data: data)
code: 1000, message: I18n.t('epp.contacts.completed'),
data: { contact: {
id: params[:id],
available: contact.nil?
} }
}, status: :ok
end end
## POST /repp/v1/contacts ## POST /repp/v1/contacts
def create def create
@legal_doc = params[:legal_documents] @legal_doc = params[:legal_documents]
@contact_params = contact_params_with_address
@ident = contact_ident_params
address_present = contact_addr_params.keys.any?
@contact = Epp::Contact.new(@contact_params, current_user.registrar, epp: false) @contact = Epp::Contact.new(contact_params_with_address, current_user.registrar, epp: false)
action = Actions::ContactCreate.new(@contact, @legal_doc, contact_ident_params)
handle_errors(@contact) and return unless action.call
action = Actions::ContactCreate.new(@contact, @legal_doc, @ident) render_success(code: opt_addr? ? 1100 : nil, data: { contact: { id: @contact.code } },
message: opt_addr? ? I18n.t('epp.contacts.completed_without_address') : nil)
if action.call
if !Contact.address_processing? && address_present
@response_code = 1100
@response_description = I18n.t('epp.contacts.completed_without_address')
else
@response_code = 1000
@response_description = I18n.t('epp.contacts.completed')
end
render(json: { code: @response_code,
message: @response_description,
data: { contact: { id: @contact.code } } },
status: :created)
else
handle_errors(@contact)
end
end end
## PUT /repp/v1/contacts/1 ## PUT /repp/v1/contacts/1
def update def update
@update = contact_params_with_address action = Actions::ContactUpdate.new(@contact, contact_params_with_address,
params[:legal_document],
contact_ident_params(required: false), current_user)
@legal_doc = params[:legal_document] handle_errors(@contact) and return unless action.call
@ident = contact_ident_params || {}
address_present = contact_addr_params.keys.any?
action = Actions::ContactUpdate.new(@contact, @update, @legal_doc, @ident, current_user)
if action.call render_success(code: opt_addr? ? 1100 : nil, data: { contact: { id: @contact.code } },
if !Contact.address_processing? && address_present message: opt_addr? ? I18n.t('epp.contacts.completed_without_address') : nil)
@response_code = 1100 end
@response_description = I18n.t('epp.contacts.completed_without_address')
else
@response_code = 1000
@response_description = I18n.t('epp.contacts.completed')
end
render(json: { code: @response_code, def contact_addr_present?
message: @response_description, return false unless contact_addr_params.key?(:addr)
data: { contact: { id: @contact.code } } },
status: :ok) contact_addr_params[:addr].keys.any?
else end
handle_errors(@contact)
end def opt_addr?
!Contact.address_processing? && contact_addr_present?
end end
def find_contact def find_contact
@ -100,9 +73,9 @@ module Repp
end end
def contact_params_with_address def contact_params_with_address
addr = {}
return contact_create_params unless contact_addr_params.key?(:addr) return contact_create_params unless contact_addr_params.key?(:addr)
addr = {}
contact_addr_params[:addr].each_key { |k| addr[k] = contact_addr_params[:addr][k] } contact_addr_params[:addr].each_key { |k| addr[k] = contact_addr_params[:addr][k] }
contact_create_params.merge(addr) contact_create_params.merge(addr)
end end
@ -112,9 +85,13 @@ module Repp
params.require(:contact).permit(:name, :email, :phone) params.require(:contact).permit(:name, :email, :phone)
end end
def contact_ident_params def contact_ident_params(required: true)
params.require(:contact).require(:ident).require(%i[ident ident_type ident_country_code]) if required
params.require(:contact).require(:ident).permit(:ident, :ident_type, :ident_country_code) params.require(:contact).require(:ident).require(%i[ident ident_type ident_country_code])
params.require(:contact).require(:ident).permit(:ident, :ident_type, :ident_country_code)
else
params.permit(ident: %i[ident ident_type ident_country_code])
end
end end
def contact_addr_params def contact_addr_params