Refactor price statuses

#522

app/models/billing/price.rb

@@ -40,10 +40,10 @@ module Billing
     end
 
     def self.statuses
-      %w[pending effective expired]
+      %w[upcoming effective expired]
     end
 
-    def self.pending
+    def self.upcoming
       where("#{attribute_alias(:effect_time)} > ?", Time.zone.now)
     end
 

spec/models/billing/price_spec.rb

@@ -45,11 +45,11 @@ RSpec.describe Billing::Price do
 
   describe '::statuses', db: false do
     it 'returns statuses' do
-      expect(described_class.statuses).to eq(%w[pending effective expired])
+      expect(described_class.statuses).to eq(%w[upcoming effective expired])
     end
   end
 
-  describe '::pending' do
+  describe '::upcoming' do
     before :example do
       travel_to Time.zone.parse('05.07.2010 00:00')
 
@@ -57,8 +57,8 @@ RSpec.describe Billing::Price do
       create(:price, id: 2, effect_time: Time.zone.parse('05.07.2010 00:01'))
     end
 
-    it 'returns pending' do
+    it 'returns upcoming' do
-      expect(described_class.pending.ids).to eq([2])
+      expect(described_class.upcoming.ids).to eq([2])
     end
   end