zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-05-17 17:59:47 +02:00
Code Issues Projects Releases Packages Wiki Activity

Return error when API user not found in REPP #2774

Browse source
This commit is contained in:
Martin Lensment 2015-07-20 18:19:02 +03:00
parent 1b9bc92660
commit f2992b7f45
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/api/repp/api.rb
View file

@ -5,6 +5,11 @@ module Repp
http_basic do |username, password| http_basic do |username, password|
@current_user ||= ApiUser.find_by(username: username, password: password) @current_user ||= ApiUser.find_by(username: username, password: password)
if @current_user
true
else
error! I18n.t('api_user_not_found'), 401
end
end end
before do before do

1
config/locales/en.yml
View file

@ -871,3 +871,4 @@ en:
parameter_value_range_error: 'Parameter value range error: %{key}' parameter_value_range_error: 'Parameter value range error: %{key}'
payment_received: 'Payment received' payment_received: 'Payment received'
domain_registrant_updated: 'Domeeni %{name} registreerija vahetus teostatud / Registrant change of %{name} has been finished.' domain_registrant_updated: 'Domeeni %{name} registreerija vahetus teostatud / Registrant change of %{name} has been finished.'
api_user_not_found: 'API user not found'

9
spec/requests/v1/domain_spec.rb
View file

@ -77,5 +77,14 @@ describe Repp::DomainV1 do
# TODO: Log failed API requests too # TODO: Log failed API requests too
end end
it 'returns an error with invalid credentials' do
invalid_user = OpenStruct.new(username: 'bla', password: 'blabala')
get_with_auth '/repp/v1/domains', {}, invalid_user
response.status.should == 401
body = JSON.parse(response.body)
body['error'].should == 'API user not found'
end
end end
end end