zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-23 11:16:00 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1208 from internetee/make-registrar-address-state-and-zip-optional

Browse source 
Make registrar address zip and state optional
This commit is contained in:
Timo Võhmar 2019-05-21 20:52:42 +03:00 • committed by GitHub
commit eed255fa20
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 27 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/fixtures/registrars.yml vendored
View file

@ -4,9 +4,7 @@ bestnames:
code: bestnames
email: info@bestnames.test
address_street: Main Street 1
address_zip: 1234
address_city: NY
address_state: NY State
address_country_code: US
accounting_customer_code: bestnames
language: en
@ -20,9 +18,7 @@ goodnames:
code: goodnames
email: info@goodnames.test
address_street: Main Street 1
address_zip: 1234
address_city: NY
address_state: NY State
address_country_code: US
vat_no: DE123456789
accounting_customer_code: goodnames
@ -35,9 +31,7 @@ not_in_use:
code: any
email: any@example.com
address_street: Main Street 1
address_zip: 1234
address_city: NY
address_state: NY State
address_country_code: US
vat_no: any
accounting_customer_code: any
@ -50,9 +44,7 @@ invalid:
code: another
email: any
address_street: Main Street 1
address_zip: 1234
address_city: NY
address_state: NY State
address_country_code: US
vat_no: any
accounting_customer_code: any

22
test/models/registrar_test.rb
View file

@ -93,16 +93,22 @@ class RegistrarTest < ActiveSupport::TestCase
Setting.days_to_keep_invoices_active = @original_days_to_keep_invoices_active_setting
end
def test_invalid_without_address
def test_invalid_without_address_street
registrar = valid_registrar
address_parts = %i[street zip city state country_code]
registrar.address_street = ''
assert registrar.invalid?
end
address_parts.each do |address_part|
attribute_name = "address_#{address_part}"
registrar.public_send("#{attribute_name}=", '')
assert registrar.invalid?, "#{attribute_name} should be required"
registrar.public_send("#{attribute_name}=", 'some')
end
def test_invalid_without_address_city
registrar = valid_registrar
registrar.address_city = ''
assert registrar.invalid?
end
def test_invalid_without_address_country_code
registrar = valid_registrar
registrar.address_country_code = ''
assert registrar.invalid?
end
def test_full_address