Enhance identical contact lookup

#746
This commit is contained in:
Artur Beljajev 2018-03-06 10:39:32 +02:00
parent c733c0910d
commit ecc68f083d
3 changed files with 67 additions and 25 deletions

View file

@ -1,30 +1,57 @@
require 'test_helper'
class ContactIdenticalTest < ActiveSupport::TestCase
REGULAR_FILTER_ATTRIBUTES = %i[
name
email
phone
fax
ident
ident_type
ident_country_code
org_name
]
def setup
@contact = contacts(:william)
@identical = contacts(:identical_to_william)
end
def test_identical
def test_returns_identical
assert_equal @identical, @contact.identical(@identical.registrar)
end
def test_not_identical
filter_attributes = %i[
name
ident
ident_type
ident_country_code
phone
email
]
def test_does_not_return_non_identical
REGULAR_FILTER_ATTRIBUTES.each do |attribute|
previous_value = @identical.public_send(attribute)
@identical.update_attribute(attribute, 'other')
assert_nil @contact.identical(@identical.registrar)
@identical.update_attribute(attribute, previous_value)
end
filter_attributes.each do |attribute|
@identical.update!({ statuses: %w[ok linked] })
assert_nil @contact.identical(@identical.registrar)
end
def test_takes_address_into_account_when_processing_enabled
Setting.address_processing = true
Contact.address_attribute_names.each do |attribute|
previous_value = @identical.public_send(attribute)
@identical.update_attribute(attribute, 'other')
assert_nil @contact.identical(@identical.registrar)
@identical.update_attribute(attribute, previous_value)
end
end
def test_ignores_address_when_processing_disabled
Setting.address_processing = false
Contact.address_attribute_names.each do |attribute|
previous_value = @identical.public_send(attribute)
@identical.update_attribute(attribute, 'other')
assert_equal @identical, @contact.identical(@identical.registrar)
@identical.update_attribute(attribute, previous_value)
end
end
end