codeclimate fixes

This commit is contained in:
dinsmol 2021-07-30 15:20:58 +03:00
parent 0c2dc9f957
commit ec1a48743c
11 changed files with 14 additions and 17 deletions

View file

@ -7,7 +7,7 @@ module Admin
@q = AdminUser.search(params[:q])
@admin_users = @q.result.page(params[:page]).order(:username)
@count = @q.result.count
@admin_users = @admin_users.per(params[:results_per_page]) if params[:results_per_page].to_i.positive?
@admin_users = @admin_users.per(params[:results_per_page]) if paginate?
end
def new

View file

@ -5,7 +5,7 @@ module Admin
def index
@q = ApiUser.includes(:registrar).search(params[:q])
@api_users = @q.result.page(params[:page])
api_users_paginate if params[:results_per_page].to_i.positive?
@api_users = @api_users.per(params[:results_per_page]) if paginate?
end
def new
@ -57,9 +57,5 @@ module Admin
def registrar
Registrar.find(params[:registrar_id])
end
def api_users_paginate
@api_users = @api_users.per(params[:results_per_page])
end
end
end

View file

@ -8,8 +8,7 @@ module Admin
@q = BankStatement.search(params[:q])
@q.sorts = 'id desc' if @q.sorts.empty?
@bank_statements = @q.result.page(params[:page])
@count = @q.result.count
@bank_statements = @bank_statements.per(params[:results_per_page]) if params[:results_per_page].to_i.positive?
@bank_statements = @bank_statements.per(params[:results_per_page]) if paginate?
end
def show

View file

@ -17,5 +17,9 @@ module Admin
def user_for_paper_trail
current_admin_user ? current_admin_user.id_role_username : 'anonymous'
end
def paginate?
params[:results_per_page].to_i.positive?
end
end
end

View file

@ -12,7 +12,7 @@ module Admin
@epp_logs = @epp_logs.where("extract(epoch from created_at) <= extract(epoch from ?::timestamp)", Time.parse(params[:q][:created_at_lteq])) if params[:q][:created_at_lteq].present?
@epp_logs = @epp_logs.page(params[:page])
@count = @q.result.count
@epp_logs = @epp_logs.per(params[:results_per_page]) if params[:results_per_page].to_i.positive?
@epp_logs = @epp_logs.per(params[:results_per_page]) if paginate?
end
def show

View file

@ -36,8 +36,7 @@ module Admin
@q = Invoice.includes(:account_activity).search(params[:q])
@q.sorts = 'number desc' if @q.sorts.empty?
@invoices = @q.result.page(params[:page])
@count = @q.result.count
@invoices = @invoices.per(params[:results_per_page]) if params[:results_per_page].to_i.positive?
@invoices = @invoices.per(params[:results_per_page]) if paginate?
end
def show; end

View file

@ -8,8 +8,7 @@ module Admin
def index
@q = Registrar.joins(:accounts).ordered.search(params[:q])
@registrars = @q.result.page(params[:page])
@count = @q.result.count
@registrars = @registrars.per(params[:results_per_page]) if params[:results_per_page].to_i.positive?
@registrars = @registrars.per(params[:results_per_page]) if paginate?
end
def new

View file

@ -12,7 +12,7 @@ module Admin
@repp_logs = @repp_logs.where("extract(epoch from created_at) <= extract(epoch from ?::timestamp)", Time.parse(params[:q][:created_at_lteq])) if params[:q][:created_at_lteq].present?
@repp_logs = @repp_logs.page(params[:page])
@count = @q.result.count
@repp_logs = @repp_logs.per(params[:results_per_page]) if params[:results_per_page].to_i.positive?
@repp_logs = @repp_logs.per(params[:results_per_page]) if paginate?
end
def show

View file

@ -33,7 +33,7 @@
</div>
<div class="col-md-6 text-right">
<div class="pagination">
<%= t(:result_count, count: @count) %>
<%= t(:result_count, count: @q.result.count) %>
</div>
</div>
</div>

View file

@ -38,4 +38,4 @@
= paginate @invoices
.col-md-6.text-right
.pagination
= t(:result_count, count: @count)
= t(:result_count, count: @q.result.count)

View file

@ -69,7 +69,7 @@
</div>
<div class="col-md-6 text-right">
<div class="pagination">
<%= t(:result_count, count: @count) %>
<%= t(:result_count, count: @q.result.count) %>
</div>
</div>
</div>