updated contact#create to new attr checking

app/helpers/epp/contacts_helper.rb

@@ -67,6 +67,17 @@ module Epp::ContactsHelper
 
   private
 
+  def validate_contact_create_request
+    @ph = params_hash['epp']['command']['create']['create']
+    xml_attrs_present?(@ph, [['id'], 
+                             ['postalInfo'], 
+                             ['postalInfo', 'name'], 
+                             ['postalInfo', 'addr'],
+                             ['postalInfo', 'addr', 'city'], 
+                             ['postalInfo', 'addr', 'cc'], 
+                             ['authInfo']])
+  end
+
   def contact_and_address_attributes
     ph = params_hash['epp']['command'][params[:command]][params[:command]]
     ph = ph[:chg] if params[:command] == 'update'

spec/epp/contact_spec.rb

@@ -6,6 +6,15 @@ describe 'EPP Contact', epp: true do
   context 'with valid user' do
     before(:each) { Fabricate(:epp_user) }
 
+    it "doesn't create contact with attributes missing" do
+      response = epp_request('contacts/create_missing_attr.xml')
+      expect(response[:results][0][:result_code]).to eq('2003')
+      expect(response[:results][1][:result_code]).to eq('2003')
+
+      expect(response[:results][0][:msg]).to eq('Required parameter missing: cc')
+      expect(response[:results][1][:msg]).to eq('Required parameter missing: authInfo')
+    end
+
     # incomplete
     it 'creates a contact' do
       response = epp_request('contacts/create.xml')

spec/epp/requests/contacts/create_missing_attr.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+  <epp xmlns="urn:ietf:params:xml:ns:epp-1.0">
+    <command>
+      <create>
+        <contact:create
+         xmlns:contact="urn:ietf:params:xml:ns:contact-1.0">
+          <contact:id>sh8013</contact:id>
+          <contact:postalInfo type="int">
+            <contact:name>John Doe</contact:name>
+            <contact:addr>
+              <contact:city>Dulles</contact:city>
+            </contact:addr>
+          </contact:postalInfo>
+          <contact:email>jdoe@example.com</contact:email>
+        </contact:create>
+      </create>
+      <clTRID>ABC-12345</clTRID>
+    </command>
+  </epp>