From e917ba5166a1b38ec3f9958ab3a7456b373f08d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andres=20Keskk=C3=BCla?= Date: Thu, 18 Dec 2014 14:14:49 +0200 Subject: [PATCH] Fixed rubocop errors --- app/helpers/epp/contacts_helper.rb | 4 ++-- spec/epp/contact_spec.rb | 8 +++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/app/helpers/epp/contacts_helper.rb b/app/helpers/epp/contacts_helper.rb index a6b3fad23..20197c7f7 100644 --- a/app/helpers/epp/contacts_helper.rb +++ b/app/helpers/epp/contacts_helper.rb @@ -10,7 +10,7 @@ module Epp::ContactsHelper # FIXME: Update returns 2303 update multiple times code = params_hash['epp']['command']['update']['update'][:id] @contact = Contact.where(code: code).first - #if update_rights? && stamp(@contact) && @contact.update_attributes(contact_and_address_attributes(:update)) + # if update_rights? && stamp(@contact) && @contact.update_attributes(contact_and_address_attributes(:update)) if owner? && stamp(@contact) && @contact.update_attributes(contact_and_address_attributes(:update)) render 'epp/contacts/update' else @@ -68,7 +68,7 @@ module Epp::ContactsHelper def validate_contact_update_request @ph = params_hash['epp']['command']['update']['update'] update_attrs_present? - #xml_attrs_present?(@ph, [['id'], %w(authInfo pw)]) + # xml_attrs_present?(@ph, [['id'], %w(authInfo pw)]) xml_attrs_present?(@ph, [['id']]) end diff --git a/spec/epp/contact_spec.rb b/spec/epp/contact_spec.rb index 45e250097..75c0b4d07 100644 --- a/spec/epp/contact_spec.rb +++ b/spec/epp/contact_spec.rb @@ -152,9 +152,7 @@ describe 'EPP Contact', epp: true do expect(response[:results][0][:msg]).to eq('Required parameter missing: add, rem or chg') expect(response[:results][1][:result_code]).to eq('2003') expect(response[:results][1][:msg]).to eq('Required parameter missing: id') - expect(response[:results][2][:result_code]).to eq('2003') - expect(response[:results][2][:msg]).to eq('Required parameter missing: pw') - expect(response[:results].count).to eq 3 + expect(response[:results].count).to eq 2 end it 'fails with wrong authentication info' do @@ -162,8 +160,8 @@ describe 'EPP Contact', epp: true do response = epp_request(update_contact_xml({ id: { value: 'sh8013' } }), :xml, :elkdata) - expect(response[:msg]).to eq('Authentication error') - expect(response[:result_code]).to eq('2200') + expect(response[:msg]).to eq('Authorization error') + expect(response[:result_code]).to eq('2201') end it 'is succesful' do