Merge pull request #2438 from internetee/ignore-statuses-update-if-invoice-already-paid

Ignore statuses update if invoice already paid

app/controllers/eis_billing/payment_status_controller.rb

@@ -5,6 +5,9 @@ module EisBilling
     def update
       payment_status = define_payment_status(params[:payment_state])
       invoice = Invoice.find_by(number: params[:order_reference])
+
+      return if invoice.paid?
+
       bank = create_bank_transfer(invoice: invoice, sum: params[:standing_amount], paid_at: params[:transaction_time])
       create_payment_order(invoice: invoice, everypay_response: params, payment_status: payment_status)
 

test/integration/eis_billing/payment_status_test.rb

@@ -0,0 +1,32 @@
+require 'test_helper'
+
+class PaymentStatusTest < ApplicationIntegrationTest
+  setup do
+    sign_in users(:api_bestnames)
+    @invoice = invoices(:one)
+    @unpaid = invoices(:unpaid)
+    @registrar = registrars(:bestnames)
+    Spy.on_instance_method(EisBilling::BaseController, :authorized).and_return(true)
+  end
+
+  def shoudl_update_buyer_balance
+    assert @invoice.paid?
+    assert_equal @invoice.buyer.balance.to_f, 100.0
+
+    payload = {
+      payment_state: 'settled',
+      order_reference: @unpaid.number,
+      standing_amount: @unpaid.total,
+      transaction_time: Time.zone.now,
+    }
+
+    put eis_billing_payment_status_path, params: payload
+
+    @invoice.reload
+    @invoice.buyer.reload
+    @registrar.reload
+
+    assert @invoice.paid?
+    assert_equal @invoice.buyer.balance.to_f, 100.0
+  end
+end