zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-25 03:58:27 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1683 from internetee/fix-einvoice-job

Browse source 
EInvoiceJob: Make payable argument required
This commit is contained in:
Timo Võhmar 2020-09-15 17:13:52 +03:00 • committed by GitHub
commit e1d379e106
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/jobs/send_e_invoice_job.rb
View file

@ -1,5 +1,5 @@
class SendEInvoiceJob < Que::Job
def run(invoice_id, payable: true)
def run(invoice_id, payable = true)
invoice = run_condition(Invoice.find_by(id: invoice_id), payable: payable)
invoice.to_e_invoice(payable: payable).deliver

2
app/models/invoice.rb
View file

@ -100,7 +100,7 @@ class Invoice < ApplicationRecord
end
def to_e_invoice(payable: true)
generator = Invoice::EInvoiceGenerator.new(self, payable: payable)
generator = Invoice::EInvoiceGenerator.new(self, payable)
generator.generate
end

2
app/models/registrar.rb
View file

@ -104,7 +104,7 @@ class Registrar < ApplicationRecord
InvoiceMailer.invoice_email(invoice: invoice, recipient: billing_email).deliver_now
end
SendEInvoiceJob.enqueue(invoice.id, payable: payable)
SendEInvoiceJob.enqueue(invoice.id, payable)
invoice
end

6
test/jobs/send_e_invoice_job_test.rb
View file

@ -13,7 +13,7 @@ class SendEInvoiceJobTest < ActiveSupport::TestCase
EInvoice::Providers::TestProvider.deliveries.clear
assert_nothing_raised do
SendEInvoiceJob.enqueue(@invoice.id)
SendEInvoiceJob.enqueue(@invoice.id, true)
end
@invoice.reload
@ -29,7 +29,7 @@ class SendEInvoiceJobTest < ActiveSupport::TestCase
stub_request(:get, "https://testfinance.post.ee/finance/erp/erpServices.wsdl").to_timeout
assert_raise HTTPClient::TimeoutError do
SendEInvoiceJob.enqueue(@invoice.id)
SendEInvoiceJob.enqueue(@invoice.id, true)
end
assert @invoicee_invoice_sent_at.blank?
@ -37,7 +37,7 @@ class SendEInvoiceJobTest < ActiveSupport::TestCase
EInvoice::Providers::TestProvider.deliveries.clear
assert_nothing_raised do
SendEInvoiceJob.enqueue(@invoice.id)
SendEInvoiceJob.enqueue(@invoice.id, true)
end
@invoice.reload