Fix EPP response code

Fixes #686
This commit is contained in:
Artur Beljajev 2019-09-14 18:58:35 +03:00
parent 77678681a6
commit e01f412d76
3 changed files with 16 additions and 6 deletions

View file

@ -182,7 +182,7 @@ module Epp
end
def transfer
authorize! :transfer, @domain, @password
authorize! :transfer, @domain
action = params[:parsed_frame].css('transfer').first[:op]
if @domain.non_transferable?
@ -194,6 +194,18 @@ module Epp
return
end
provided_transfer_code = params[:parsed_frame].css('authInfo pw').text
wrong_transfer_code = provided_transfer_code != @domain.transfer_code
if wrong_transfer_code
epp_errors << {
code: '2202',
msg: 'Invalid authorization information',
}
handle_errors
return
end
@domain_transfer = @domain.transfer(params[:parsed_frame], action, current_user)
if @domain.errors[:epp_errors].any?

View file

@ -30,8 +30,7 @@ class EppDomainTransferQueryTest < EppTestCase
post '/epp/command/transfer', { frame: request_xml }, { 'HTTP_COOKIE' => 'session=api_bestnames' }
# https://github.com/internetee/registry/issues/686
assert_epp_response :authorization_error
assert_epp_response :invalid_authorization_information
end
def test_no_domain_transfer

View file

@ -115,10 +115,9 @@ class EppDomainTransferRequestTest < EppTestCase
post '/epp/command/transfer', { frame: request_xml }, { 'HTTP_COOKIE' => 'session=api_goodnames' }
@domain.reload
refute_equal @new_registrar, @domain.registrar
# https://github.com/internetee/registry/issues/686
assert_epp_response :authorization_error
assert_epp_response :invalid_authorization_information
refute_equal @new_registrar, @domain.registrar
end
private