From daeb00ebe7719689703cee1ad5d469e01cef4ffe Mon Sep 17 00:00:00 2001
From: Artur Beljajev <artur.beljajev@internet.ee>
Date: Fri, 13 Sep 2019 21:06:23 +0300
Subject: [PATCH] Change EPP response code according to its specification

Fixes #587
---
 app/controllers/epp/sessions_controller.rb   | 4 ++--
 app/models/epp/response/result/code.rb       | 2 ++
 test/integration/epp/login_test.rb           | 2 +-
 test/models/epp/response/result/code_test.rb | 2 ++
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/app/controllers/epp/sessions_controller.rb b/app/controllers/epp/sessions_controller.rb
index df706b55d..04603dbe7 100644
--- a/app/controllers/epp/sessions_controller.rb
+++ b/app/controllers/epp/sessions_controller.rb
@@ -79,8 +79,8 @@ module Epp
 
       if success && EppSession.limit_reached?(@api_user.registrar)
         epp_errors << {
-          msg: 'Authentication error; server closing connection (connection limit reached)',
-          code: '2501'
+          msg: 'Session limit exceeded; server closing connection (connection limit reached)',
+          code: '2502',
         }
 
         success = false
diff --git a/app/models/epp/response/result/code.rb b/app/models/epp/response/result/code.rb
index 1be4a3f7c..10edf0a35 100644
--- a/app/models/epp/response/result/code.rb
+++ b/app/models/epp/response/result/code.rb
@@ -30,6 +30,7 @@ module Epp
           data_management_policy_violation: 2308,
           command_failed: 2400,
           authentication_error_server_closing_connection: 2501,
+          session_limit_exceeded_server_closing_connection: 2502,
         }.freeze
         private_constant :KEY_TO_VALUE
 
@@ -59,6 +60,7 @@ module Epp
           2308 => 'Data management policy violation',
           2400 => 'Command failed',
           2501 => 'Authentication error; server closing connection',
+          2502 => 'Session limit exceeded; server closing connection',
         }.freeze
         private_constant :DEFAULT_DESCRIPTIONS
 
diff --git a/test/integration/epp/login_test.rb b/test/integration/epp/login_test.rb
index fe8ef2cf8..7442728a0 100644
--- a/test/integration/epp/login_test.rb
+++ b/test/integration/epp/login_test.rb
@@ -169,6 +169,6 @@ class EppLoginTest < EppTestCase
     assert_no_difference 'EppSession.count' do
       post '/epp/session/login', { frame: request_xml }, 'HTTP_COOKIE' => 'session=new-session-id'
     end
-    assert_epp_response :authentication_error_server_closing_connection
+    assert_epp_response :session_limit_exceeded_server_closing_connection
   end
 end
diff --git a/test/models/epp/response/result/code_test.rb b/test/models/epp/response/result/code_test.rb
index f16013180..184a18438 100644
--- a/test/models/epp/response/result/code_test.rb
+++ b/test/models/epp/response/result/code_test.rb
@@ -51,6 +51,7 @@ class EppResponseResultCodeTest < ActiveSupport::TestCase
       data_management_policy_violation: 2308,
       command_failed: 2400,
       authentication_error_server_closing_connection: 2501,
+      session_limit_exceeded_server_closing_connection: 2502,
     }
     assert_equal codes, Epp::Response::Result::Code.codes
   end
@@ -82,6 +83,7 @@ class EppResponseResultCodeTest < ActiveSupport::TestCase
       2308 => 'Data management policy violation',
       2400 => 'Command failed',
       2501 => 'Authentication error; server closing connection',
+      2502 => 'Session limit exceeded; server closing connection',
     }
     assert_equal descriptions, Epp::Response::Result::Code.default_descriptions
   end